Add initial entry point for vault flows with SDK token #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravishekhar
approved these changes
Apr 17, 2024
| return options.customer_id || ""; | ||
| } | ||
|
|
||
| return ""; |
There was a problem hiding this comment.
Should we return a null in case there is no customer id?
wsbrunson
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an initial entrance to allow the latest vault flow (ID token) to work the new SDK token. It will not enable the e2e flow just yet.
When SDK token is passed alone, internally we will set the ID token as the SDK token value. We also will use this new getCustomerId function that decodes the SDK token for UX improvements to prevent an API call/correct loading state.