Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix node 18 type error #188

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Fix node 18 type error #188

merged 1 commit into from
Feb 22, 2024

Conversation

jshawl
Copy link
Member

@jshawl jshawl commented Feb 22, 2024

This PR fixes an issue where crypto.subtle.verify expects a byte array for the signature instead of a string. see https://github.com/paypal/paypal-sdk-client/actions/runs/8009694187/job/21878949911#step:7:204

After this PR is merged, I would like to submit another PR to update the node version in main.yml:

uses: actions/setup-node@v3
with:
node-version: "16"

because it differs from the publish action's node version:

- name: 🤝 Set Node version from .nvmrc
run: echo NVMRC=`cat .nvmrc` >> $GITHUB_ENV
- name: ⎔ Setup node
# sets up the .npmrc file to publish to npm
uses: actions/setup-node@v3
with:
node-version: ${{ env.NVMRC }}

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (639b4d5) 73.66% compared to head (a7fe098) 73.66%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #188   +/-   ##
=======================================
  Coverage   73.66%   73.66%           
=======================================
  Files          23       23           
  Lines        2035     2035           
  Branches      240      240           
=======================================
  Hits         1499     1499           
  Misses        526      526           
  Partials       10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jshawl jshawl marked this pull request as ready for review February 22, 2024 19:26
@jshawl jshawl requested a review from a team as a code owner February 22, 2024 19:26
@jshawl jshawl merged commit 4b87e82 into main Feb 22, 2024
5 checks passed
@jshawl jshawl deleted the fix-typeerror branch February 22, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants