Skip to content

fix(storage-gcs): correctly handle alwaysInsertFields #15541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
r1tsuu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(storage-gcs): correctly handle alwaysInsertFields #15541

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions packages/storage-gcs/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,29 @@ export const gcsStorage: GcsStoragePlugin =
})

if (isPluginDisabled) {
// If alwaysInsertFields is true, still call cloudStoragePlugin to insert fields
if (gcsStorageOptions.alwaysInsertFields) {
// Build collections with adapter: null since plugin is disabled
const collectionsWithoutAdapter: CloudStoragePluginOptions['collections'] = Object.entries(
gcsStorageOptions.collections,
).reduce(
(acc, [slug, collOptions]) => ({
...acc,
[slug]: {
...(collOptions === true ? {} : collOptions),
adapter: null,
},
}),
{} as Record<string, CollectionOptions>,
)

return cloudStoragePlugin({
alwaysInsertFields: true,
collections: collectionsWithoutAdapter,
enabled: false,
})(incomingConfig)
}

return incomingConfig
}

Expand Down