Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for PostgreSQL 11 #236

Merged
merged 4 commits into from
Jul 12, 2019
Merged

Conversation

weasellin
Copy link
Contributor

Resolving #221.

Upgrade the required extensions version for Postgres-11

  • Upgrade pg_repack from 1.4.3 to 1.4.4
  • Upgrade PostGIS from 2.4 to 2.5
    • The 2.4 release (currently 2.4.7) only supports PostgreSQL 9.3-10.
    • The 2.5 release (currently 2.5.2) supports PostgreSQL 9.3-11.
    • Referring to this release note.

weasellin added 2 commits July 3, 2019 10:34
- Upgrade `pg_repack` from 1.4.3 to 1.4.4
  - To include the [fixing of the build failure](reorg/pg_repack#191).
- Upgrade PostGIS from 2.4 to 2.5
  - The 2.4 release (currently 2.4.7) only supports PostgreSQL 9.3-10.
  - The 2.5 release (currently 2.5.2) supports PostgreSQL 9.3-11.
  - Referring to [this release note](https://postgis.net/2019/03/11/postgis-patches/).
@@ -1,7 +1,7 @@

##########################################################################
## AUTO-GENERATED FILE ##
## BUILD_NUMBER=Sat 27 Apr 2019 12:29:35 +08 ##
## BUILD_NUMBER=Wed Jul 3 10:29:46 JST 2019 ##
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really want to commit generated files with just a timestamp change?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we can stop doing it - would be nice.
Just keep in mind this build number is used for https://github.com/paunin/PostDock/blob/master/make/make.sh#L11

@paunin
Copy link
Owner

paunin commented Jul 6, 2019

Thanks for the PR!

Think something goes wrong with pg11
https://travis-ci.org/paunin/PostDock/jobs/553642951
image

@weasellin
Copy link
Contributor Author

Thanks for the PR!

Think something goes wrong with pg11
https://travis-ci.org/paunin/PostDock/jobs/553642951
image

Hi paunin,

Thanks for your reply.
Sorry, I didn't carefully enough to check the compatibility matrix for pg & repmgr.

According to the current repmgr compatibility matrix,
the repmgr 3.x only supports to pg 9.3 to 9.6, not for 10 nor 11.

So for pg11 + repmgr3.2, we might have to remove them from the combinations.
Also the repmgr3.x has been already out of maintained or supported.

But for pg10 + repmgr3.2, it's interesting even they are not in the compatibility matrix, there still are packages available in the packages site.
Any comment or consideration to keep pg10 + repmgr3.2 or not?

@paunin
Copy link
Owner

paunin commented Jul 8, 2019

Let's not introduce pg11 + repmgr3.x.
Let's keep what already there e.g. pg10 + repmgr3.2 - as long as tests pass should be fine (but yeah - might need separate PR do disintegrate it)

But tests are failing even for pg11 + repmgr4... iа you can fix it - I'll be happy to merge it

@paunin
Copy link
Owner

paunin commented Jul 8, 2019

@paunin
Copy link
Owner

paunin commented Jul 8, 2019

https://travis-ci.org/paunin/PostDock/builds/555554327 still fails for your combination - think you need to inverstigate

@paunin
Copy link
Owner

paunin commented Jul 8, 2019

not fails buttiming out

@weasellin
Copy link
Contributor Author

https://travis-ci.org/paunin/PostDock/builds/555554327 still fails for your combination - think you need to inverstigate

Ok, let me investigate.

In postgres 11, the `postgres: wal receiver process` command is changed
to `postgres: walreceiver process`.
@paunin paunin merged commit 3534b9e into paunin:master Jul 12, 2019
@paunin paunin mentioned this pull request Jul 12, 2019
@weasellin weasellin deleted the ISSUE-221-postgres11 branch July 12, 2019 14:24
@weasellin
Copy link
Contributor Author

Partial duplicated with #231

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants