Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Create chatbot docs #151

Open
wants to merge 6 commits into
base: v6
Choose a base branch
from

Conversation

nicolethoen
Copy link
Contributor

No description provided.

@patternfly-build
Copy link

patternfly-build commented Sep 19, 2024

@nicolethoen
Copy link
Contributor Author

Ah - so a benefit to exposing each piece individually in the documentation, is they get a more thorough a11y review! :)
So the prompts in the Welcome prompt example have wonky labels, and so I"ll clean this up as part of this, but I'm very open to feedback on the content of the docs themselves!

Copy link

@edonehoo edonehoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some general comments/ideas! I like what you have so far, but I also can't view the preview link yet, so I don't have a ton of visibility 😭

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a general comment, I think the navigation plan is to have a top level "PatternFly AI" category, with "Chatbot" nested underneath (and also our AI guidelines).

So maybe something like this? Granted I may have a different opinion after getting to interact with the docs (surge 504), depending on the range of docs we will be adding

  • PatternFly AI
    • About PatternFly AI
    • Ethics and guidelines
    • Chatbot
      • About chatbot - higher level overview and design guidelines with screenshots. maybe a table/outline of the different components available within the chatbot?
      • Chatbot components - basic chatbot features, the stuff that is "required" or semi-required, unless that list is too long
      • Chatbot attachments
      • Writing for chatbots
      • etc.


```js file="./Chatbot.tsx" isFullscreen

### Chatbot container in various display modes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Chatbot container in various display modes
### Container
The chatbot container adapts to various display modes, as well as both light and dark themes.

If we were to call this page "chatbot components" we could maybe shorten some of these headings?

Comment on lines +31 to +35
### Chatbot content and message box

The `ChatbotContent` component is the container that is placed within the `Chatbot` between the [ChatbotHeader](/extensions/chat-bots--ai/chatbot-header) and [ChatbotFooter](/extensions/chat-bots--ai/chatbot-footer).
It usually contains a `ChatbotMessageBox` for displaying messages.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Chatbot content and message box
The `ChatbotContent` component is the container that is placed within the `Chatbot` between the [ChatbotHeader](/extensions/chat-bots--ai/chatbot-header) and [ChatbotFooter](/extensions/chat-bots--ai/chatbot-footer).
It usually contains a `ChatbotMessageBox` for displaying messages.
### Chatbot content and message box
The `<ChatbotContent>` component is the container that is placed within the `<Chatbot>`, between the [`<ChatbotHeader>`](/extensions/chat-bots--ai/chatbot-header) and [`<ChatbotFooter>`](/extensions/chat-bots--ai/chatbot-footer).
It usually contains a `<ChatbotMessageBox>` for displaying messages.

Comment on lines +48 to +51
### Chatbot welcome prompt

The welcome prompt fills the message box before the user has input their first message to the chatbot. It can contain pre determined prompts

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Chatbot welcome prompt
The welcome prompt fills the message box before the user has input their first message to the chatbot. It can contain pre determined prompts
### Welcome prompt
The welcome prompt fills the message box before the user has input their first message to the chatbot. This message should welcome users to the chatbot experience and encourage them to interact. It may be helpful to display predetermined prompts as a starting point.

If there are a couple of general examples of predetermined prompts we could add at the end too

Comment on lines +48 to +51
import PFHorizontalLogoColor from '../ChatbotHeader/PF-HorizontalLogo-Color.svg';
import PFHorizontalLogoReverse from '../ChatbotHeader/PF-HorizontalLogo-Reverse.svg';

### Basic example

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import PFHorizontalLogoColor from '../ChatbotHeader/PF-HorizontalLogo-Color.svg';
import PFHorizontalLogoReverse from '../ChatbotHeader/PF-HorizontalLogo-Reverse.svg';
### Basic example
import PFHorizontalLogoColor from '../ChatbotHeader/PF-HorizontalLogo-Color.svg';
import PFHorizontalLogoReverse from '../ChatbotHeader/PF-HorizontalLogo-Reverse.svg';
### Basic chatbot

Copy link
Member

@rebeccaalpert rebeccaalpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave commenting on the docs structure and content to Erin. I didn't check to see if her changes were applied, but I pulled this down and everything appears to be working correctly. Nice fix on the docs for the FileDropZone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants