Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ChatbotHeader): Adjust spacing #148

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Conversation

rebeccaalpert
Copy link
Member

No description provided.

@patternfly-build
Copy link

patternfly-build commented Sep 16, 2024

@andrew-ronaldson
Copy link

andrew-ronaldson commented Sep 19, 2024

Screenshot 2024-09-19 at 9 47 28 AM Not sure if this has been discussed yet and apologies if this is a repeat but there is a `pf-m-xl` modifier on the Action button and the nav icon has a `pf-m-lg` modifier. I think both should be using `pf-m-lg` (screenshot above). There is also a colour difference on the two buttons.

@rebeccaalpert
Copy link
Member Author

Screenshot 2024-09-19 at 9 47 28 AM Not sure if this has been discussed yet and apologies if this is a repeat but there is a pf-m-xl modifier on the Action button and the nav icon has a pf-m-lg modifier. I think both should be using pf-m-lg (screenshot above). There is also a colour difference on the two buttons.

Hi @andrew-ronaldson - I was leaving this open mostly so I could discuss with Kayla what to do about padding. I just pushed some updates that should fix the issues you raised. I'll take this out of draft when I meet with Kayla later today to work out the padding.

@rebeccaalpert rebeccaalpert changed the title Draft: fix(ChatbotHeader): Adjust spacing fix(ChatbotHeader): Adjust spacing Sep 19, 2024
Copy link
Contributor

@nicolethoen nicolethoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked this locally and it looks lovely 🥇

@nicolethoen nicolethoen merged commit a5c698f into patternfly:v6 Sep 19, 2024
7 checks passed
Copy link

🎉 This PR is included in version 2.0.0-alpha.33 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants