fix(CodeModal): Adjust styles to match Kayla's design #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebeccaalpert
force-pushed
the
code-modal-updates
branch
from
bd8dfe4
to
4e8aacd
Compare
rebeccaalpert
changed the title
rebeccaalpert
changed the title
rebeccaalpert
force-pushed
the
code-modal-updates
branch
from
4e8aacd
to
895830b
Compare
rebeccaalpert
changed the title
|
It looks good in the demos - but the #preview-attachment-in-modal example has some weird styling. I think it's related to something strange in the dropzone example spilling over into other examples... I will need to investigate and I don't think that should hold this up. I'll open up a follow up issue. |
nicolethoen
approved these changes
Sep 19, 2024
|
🎉 This PR is included in version 2.0.0-alpha.32 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one depends on #135 merging first; I have commits from there in here.
Kayla says this is fine, so we're good to review after #135 is in.