fix(AttachMenu): Update styles and fix bug #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolethoen
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Hey! Everything is looking pretty good 💯 I noticed that the pod attachment icon color apart of the "class = pf-v6-c-menu__item pf-chatbot__object" is the incorrect color, looks like its pulled in as an svg. Can we adjust that semantic color token to be pf-t--global--icon--color--status--custom--default ? thanks!
|
Addressed design feedback! |
rebeccaalpert
force-pushed
the
attach-updates
branch
5 times, most recently
from
e610d5e
to
7ff7981
Compare
kaylachumley
suggested changes
Sep 17, 2024
Updated styles to use Kayla's tokens and fixed a bug related to React keys.
rebeccaalpert
force-pushed
the
attach-updates
branch
from
7ff7981
to
2d37fde
Compare
|
Hover state should be all set! |
|
🎉 This PR is included in version 2.0.0-alpha.30 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated styles to use Kayla's tokens and fixed a bug related to React keys.