Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(beta): Updated to the latest beta and merged updates from main. #74

Merged
merged 6 commits into from
Aug 7, 2024

Conversation

dlabaj
Copy link
Contributor

@dlabaj dlabaj commented Jul 30, 2024

This PR updates to the latest beta version and brings over all the updates that have happened in the main branch.

PR Preview can be found here: https://questionable-celery.surge.sh

Copy link
Collaborator

@nicolethoen nicolethoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create an issue to track removing the usage of the deprecated modal in the future.

Also, I think there should be an issue to track this comment left in a previous PR by @andrew-ronaldson. I noticed the issue still isn't resolved in your surge preview:
#73 (comment)

@edonehoo
Copy link
Contributor

edonehoo commented Jul 31, 2024

Probably a good idea to follow up and remove the lorem text in the examples (not that this was the result of this pr):
image

I can open an issue if you agree!

@andrew-ronaldson
Copy link

I still see this padding issue with the background-image. Looks like a bug right now so I think the we need a a way to offset the padding back to the edge of the modal.
Screenshot 2024-08-06 at 12 43 22 PM

@dlabaj
Copy link
Contributor Author

dlabaj commented Aug 7, 2024

Screenshot 2024-08-07 at 2 58 39 PM

@andrew-ronaldson All set andrew

@andrew-ronaldson andrew-ronaldson self-requested a review August 7, 2024 20:04
Copy link

@andrew-ronaldson andrew-ronaldson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating. Ship it!

@dlabaj dlabaj merged commit e67f87e into patternfly:v6 Aug 7, 2024
4 checks passed
Copy link

github-actions bot commented Aug 7, 2024

🎉 This PR is included in version 6.0.0-alpha.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

🎉 This PR is included in version 6.0.0-prerelease.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants