Skip to content

Commit 2f569b4

Browse files
authored
Merge pull request #60 from thatblindgeye/iss45_consumeV6Alphas
feat(v6): consume v6 alphas
2 parents 398642b + 11097d3 commit 2f569b4

File tree

14 files changed

+376
-209
lines changed

14 files changed

+376
-209
lines changed

.github/workflows/build-lint-test.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
fi
1717
- uses: actions/setup-node@v3
1818
with:
19-
node-version: '16'
19+
node-version: '18'
2020
- uses: actions/cache@v2
2121
id: yarn-cache
2222
name: Cache npm deps

.github/workflows/build.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ jobs:
3232
if: steps.setup-cache.outputs.cache-hit != 'true'
3333
- uses: actions/setup-node@v3
3434
with:
35-
node-version: '16'
35+
node-version: '18'
3636
- uses: actions/cache@v2
3737
id: yarn-cache
3838
name: Cache npm deps

.github/workflows/promote.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
run: yarn install --frozen-lockfile && yarn build
1818
- uses: actions/setup-node@v3
1919
with:
20-
node-version: '16.x'
20+
node-version: '18.x'
2121
registry-url: 'https://registry.npmjs.org'
2222
- name: GitHub Tag Name example
2323
run: |

.github/workflows/release.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
- uses: actions/checkout@v2
1818
- uses: actions/setup-node@v3
1919
with:
20-
node-version: '16'
20+
node-version: '18'
2121
- uses: actions/cache@v2
2222
id: yarn-cache
2323
name: Cache npm deps

packages/module/package.json

+7-7
Original file line numberDiff line numberDiff line change
@@ -28,21 +28,21 @@
2828
},
2929
"homepage": "https://github.com/patternfly/react-log-viewer#readme",
3030
"dependencies": {
31-
"@patternfly/react-core": "^6.0.0-alpha.1",
32-
"@patternfly/react-icons": "^6.0.0-alpha.1",
33-
"@patternfly/react-styles": "^6.0.0-alpha.1",
31+
"@patternfly/react-core": "6.0.0-alpha.48",
32+
"@patternfly/react-icons": "6.0.0-alpha.18",
33+
"@patternfly/react-styles": "6.0.0-alpha.18",
3434
"memoize-one": "^5.1.0"
3535
},
3636
"peerDependencies": {
3737
"react": "^17 || ^18",
3838
"react-dom": "^17 || ^18"
3939
},
4040
"devDependencies": {
41-
"@patternfly/documentation-framework": "^5.2.20",
42-
"@patternfly/patternfly": "^6.0.0-alpha.9",
43-
"@patternfly/react-table": "^6.0.0-alpha.1",
41+
"@patternfly/documentation-framework": "6.0.0-alpha.18",
42+
"@patternfly/patternfly": "6.0.0-alpha.109",
43+
"@patternfly/react-table": "6.0.0-alpha.48",
4444
"@patternfly/patternfly-a11y": "^4.3.1",
45-
"@patternfly/react-code-editor": "^6.0.0-alpha.1",
45+
"@patternfly/react-code-editor": "6.0.0-alpha.48",
4646
"resize-observer-polyfill": "^1.5.1",
4747
"tslib": "^2.0.0",
4848
"react-monaco-editor": "^0.51.0",

packages/module/patternfly-docs/content/extensions/react-log-viewer/demos/ComplexToolbarLogViewer.jsx

+4-3
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import {
66
Button,
77
MenuToggle,
88
Select,
9+
SelectList,
910
SelectOption,
1011
Tooltip,
1112
Toolbar,
@@ -164,7 +165,7 @@ const ComplexToolbarLogViewer = () => {
164165
const leftAlignedToolbarGroup = (
165166
<React.Fragment>
166167
<ToolbarToggleGroup toggleIcon={<EllipsisVIcon />} breakpoint="md">
167-
<ToolbarItem variant="search-filter">
168+
<ToolbarItem>
168169
<Select
169170
toggle={toggle}
170171
onOpenChange={(isOpen) => setSelectDataSourceOpen(isOpen)}
@@ -181,10 +182,10 @@ const ComplexToolbarLogViewer = () => {
181182
isOpen={selectDataSourceOpen}
182183
placeholderText={selectDataSourcePlaceholder}
183184
>
184-
{selectDataSourceMenu}
185+
<SelectList>{selectDataSourceMenu}</SelectList>
185186
</Select>
186187
</ToolbarItem>
187-
<ToolbarItem variant="search-filter">
188+
<ToolbarItem>
188189
<LogViewerSearch onFocus={(_e) => setIsPaused(true)} placeholder="Search" />
189190
</ToolbarItem>
190191
</ToolbarToggleGroup>

packages/module/patternfly-docs/content/extensions/react-log-viewer/demos/LogViewer.md

+12-11
Original file line numberDiff line numberDiff line change
@@ -7,17 +7,18 @@ source: react-demos
77
import { data } from '../examples/realTestData';
88
import { LogViewer, LogViewerSearch } from '@patternfly/react-log-viewer';
99
import {
10-
Badge,
11-
Button,
12-
MenuToggle,
13-
Select,
14-
SelectOption,
15-
Tooltip,
16-
Toolbar,
17-
ToolbarContent,
18-
ToolbarGroup,
19-
ToolbarItem,
20-
ToolbarToggleGroup
10+
Badge,
11+
Button,
12+
MenuToggle,
13+
Select,
14+
SelectList,
15+
SelectOption,
16+
Tooltip,
17+
Toolbar,
18+
ToolbarContent,
19+
ToolbarGroup,
20+
ToolbarItem,
21+
ToolbarToggleGroup
2122
} from '@patternfly/react-core';
2223
import OutlinedPlayCircleIcon from '@patternfly/react-icons/dist/esm/icons/outlined-play-circle-icon';
2324
import ExpandIcon from '@patternfly/react-icons/dist/esm/icons/expand-icon';

packages/module/patternfly-docs/generated/extensions/log-viewer/design-guidelines.js

+1-3
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ const pageData = {
1010
"section": "extensions",
1111
"subsection": "",
1212
"deprecated": false,
13+
"template": false,
1314
"beta": false,
1415
"demo": false,
1516
"newImplementationLink": false,
@@ -18,9 +19,6 @@ const pageData = {
1819
"slug": "/extensions/log-viewer/design-guidelines",
1920
"sourceLink": "https://github.com/patternfly/patternfly-org/blob/main/packages/module/patternfly-docs/content/extensions/react-log-viewer/design-guidelines/design-guidelines.md",
2021
"relPath": "packages/module/patternfly-docs/content/extensions/react-log-viewer/design-guidelines/design-guidelines.md"
21-
};
22-
pageData.relativeImports = {
23-
2422
};
2523
pageData.examples = {
2624

packages/module/patternfly-docs/generated/extensions/log-viewer/react-demos.js

+16-15
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/module/patternfly-docs/generated/extensions/log-viewer/react.js

+2-3
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ const pageData = {
88
"section": "extensions",
99
"subsection": "",
1010
"deprecated": false,
11+
"template": false,
1112
"beta": false,
1213
"demo": false,
1314
"newImplementationLink": false,
@@ -145,9 +146,7 @@ pageData.liveContext = {
145146
ToolbarItem,
146147
data
147148
};
148-
pageData.relativeImports = {
149-
150-
};
149+
pageData.relativeImports = "import { data } from 'content/extensions/react-log-viewer/examples/./realTestData';"
151150
pageData.examples = {
152151
'Basic': props =>
153152
<Example {...pageData} {...props} {...{"code":"import React from 'react';\nimport { data } from './realTestData';\nimport { LogViewer } from '@patternfly/react-log-viewer';\nimport { Checkbox } from '@patternfly/react-core';\n\nconst BasicLogViewer = () => {\n const [isDarkTheme, setIsDarkTheme] = React.useState(false);\n\n return (\n <React.Fragment>\n <Checkbox\n label=\"Dark theme\"\n isChecked={isDarkTheme}\n onChange={(_event, value) => setIsDarkTheme(value)}\n aria-label=\"toggle dark theme checkbox\"\n id=\"toggle-dark-theme\"\n name=\"toggle-dark-theme\"\n />\n <LogViewer hasLineNumbers={false} height={300} data={data.data} theme={isDarkTheme ? 'dark' : 'light'} />\n </React.Fragment>\n );\n};\n\nexport default BasicLogViewer;","title":"Basic","lang":"js"}}>
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
module.exports = {
2-
'/extensions/log-viewer/react-demos': {
2+
'/extensions/log-viewer/react': {
33
id: "Log viewer",
44
title: "Log viewer",
5-
toc: [[{"text":"With complex toolbar"}]],
6-
examples: ["With complex toolbar"],
5+
toc: [{"text":"Examples"},[{"text":"Basic"},{"text":"With search"},{"text":"With complex toolbar"},{"text":"With header component"},{"text":"With footer component"},{"text":"With ANSI color logs"}]],
6+
examples: ["Basic","With search","With complex toolbar","With header component","With footer component","With ANSI color logs"],
77
section: "extensions",
88
subsection: "",
9-
source: "react-demos",
9+
source: "react",
1010
tabName: null,
11-
Component: () => import(/* webpackChunkName: "extensions/log-viewer/react-demos/index" */ './extensions/log-viewer/react-demos')
11+
Component: () => import(/* webpackChunkName: "extensions/log-viewer/react/index" */ './extensions/log-viewer/react')
1212
},
1313
'/extensions/log-viewer/design-guidelines': {
1414
id: "Log viewer",
@@ -20,15 +20,15 @@ module.exports = {
2020
tabName: null,
2121
Component: () => import(/* webpackChunkName: "extensions/log-viewer/design-guidelines/index" */ './extensions/log-viewer/design-guidelines')
2222
},
23-
'/extensions/log-viewer/react': {
23+
'/extensions/log-viewer/react-demos': {
2424
id: "Log viewer",
2525
title: "Log viewer",
26-
toc: [{"text":"Examples"},[{"text":"Basic"},{"text":"With search"},{"text":"With complex toolbar"},{"text":"With header component"},{"text":"With footer component"},{"text":"With ANSI color logs"}]],
27-
examples: ["Basic","With search","With complex toolbar","With header component","With footer component","With ANSI color logs"],
26+
toc: [[{"text":"With complex toolbar"}]],
27+
examples: ["With complex toolbar"],
2828
section: "extensions",
2929
subsection: "",
30-
source: "react",
30+
source: "react-demos",
3131
tabName: null,
32-
Component: () => import(/* webpackChunkName: "extensions/log-viewer/react/index" */ './extensions/log-viewer/react')
32+
Component: () => import(/* webpackChunkName: "extensions/log-viewer/react-demos/index" */ './extensions/log-viewer/react-demos')
3333
}
3434
};

packages/module/patternfly-docs/pages/index.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ const centerStyle = {
1010

1111
const IndexPage = () => {
1212
return (
13-
<PageSection variant="light" style={centerStyle}>
13+
<PageSection style={centerStyle}>
1414
<div style={{ flex: 'none', textAlign: 'center' }}>
1515
<Title size="4xl" headingLevel="h1">
1616
My extension docs

packages/module/src/LogViewer/LogViewer.tsx

+4-4
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@ const LogViewerBase: React.FunctionComponent<LogViewerProps> = memo(
201201
setIndexWidth(parseFloat(dummyIndexStyles.width));
202202
// remove dummy elements from the DOM tree
203203
containerRef.current.removeChild(dummyList);
204-
setListKey(listKey => listKey + 1);
204+
setListKey((listKey) => listKey + 1);
205205
};
206206

207207
const scrollToRowInFocus = (searchedRowIndex: searchedKeyWordType) => {
@@ -211,14 +211,14 @@ const LogViewerBase: React.FunctionComponent<LogViewerProps> = memo(
211211
// if the keyword is out of the window when wrapping text
212212
if (!isTextWrapped) {
213213
setTimeout(() => {
214-
const element = containerRef.current.querySelector('.pf-v5-c-log-viewer__string.pf-m-current');
214+
const element = containerRef.current.querySelector('.pf-v6-c-log-viewer__string.pf-m-current');
215215
element && element.scrollIntoView({ block: 'nearest', inline: 'center' });
216216
}, 1);
217217
}
218218
};
219219

220220
useEffect(() => {
221-
setListKey(listKey => listKey + 1);
221+
setListKey((listKey) => listKey + 1);
222222
}, [isTextWrapped]);
223223

224224
const guessRowHeight = (rowIndex: number) => {
@@ -272,7 +272,7 @@ const LogViewerBase: React.FunctionComponent<LogViewerProps> = memo(
272272
)}
273273
{...(initialIndexWidth && {
274274
style: {
275-
'--pf-v5-c-log-viewer--line-number-chars': initialIndexWidth + 1
275+
'--pf-v6-c-log-viewer--line-number-chars': initialIndexWidth + 1
276276
} as React.CSSProperties
277277
})}
278278
{...props}

0 commit comments

Comments
 (0)