Skip to content

Commit 398642b

Browse files
Merge pull request #49 from patternfly/upgradeDeprecatedComponents
Remove deprecated v4 components, add v5 components
2 parents 3da4f07 + 785b092 commit 398642b

File tree

3 files changed

+69
-60
lines changed

3 files changed

+69
-60
lines changed

packages/module/patternfly-docs/content/extensions/react-log-viewer/demos/ComplexToolbarLogViewer.jsx

+43-33
Original file line numberDiff line numberDiff line change
@@ -2,19 +2,18 @@ import React from 'react';
22
import { data } from '../examples/realTestData';
33
import { LogViewer, LogViewerSearch } from '@patternfly/react-log-viewer';
44
import {
5-
Badge,
6-
Button,
7-
Tooltip,
8-
Toolbar,
9-
ToolbarContent,
10-
ToolbarGroup,
11-
ToolbarItem,
12-
ToolbarToggleGroup
5+
Badge,
6+
Button,
7+
MenuToggle,
8+
Select,
9+
SelectOption,
10+
Tooltip,
11+
Toolbar,
12+
ToolbarContent,
13+
ToolbarGroup,
14+
ToolbarItem,
15+
ToolbarToggleGroup
1316
} from '@patternfly/react-core';
14-
import {
15-
Select as SelectDeprecated,
16-
SelectOption as SelectOptionDeprecated
17-
} from '@patternfly/react-core/deprecated';
1817
import OutlinedPlayCircleIcon from '@patternfly/react-icons/dist/esm/icons/outlined-play-circle-icon';
1918
import ExpandIcon from '@patternfly/react-icons/dist/esm/icons/expand-icon';
2019
import PauseIcon from '@patternfly/react-icons/dist/esm/icons/pause-icon';
@@ -44,7 +43,7 @@ const ComplexToolbarLogViewer = () => {
4443
React.useEffect(() => {
4544
setTimer(
4645
window.setInterval(() => {
47-
setItemCount(itemCount => itemCount + 1);
46+
setItemCount((itemCount) => itemCount + 1);
4847
}, 500)
4948
);
5049
return () => {
@@ -74,7 +73,7 @@ const ComplexToolbarLogViewer = () => {
7473
}
7574
}, [isPaused, buffer]);
7675

77-
const onExpandClick = _event => {
76+
const onExpandClick = (_event) => {
7877
const element = document.querySelector('#complex-toolbar-demo');
7978

8079
if (!isFullScreen) {
@@ -111,6 +110,10 @@ const ComplexToolbarLogViewer = () => {
111110
document.body.removeChild(element);
112111
};
113112

113+
const onToggleClick = () => {
114+
setSelectDataSourceOpen(!selectDataSourceOpen);
115+
};
116+
114117
const onScroll = ({ scrollOffsetToBottom, _scrollDirection, scrollUpdateWasRequested }) => {
115118
if (!scrollUpdateWasRequested) {
116119
if (scrollOffsetToBottom > 0) {
@@ -122,15 +125,15 @@ const ComplexToolbarLogViewer = () => {
122125
};
123126

124127
const selectDataSourceMenu = Object.entries(dataSources).map(([value, { type }]) => (
125-
<SelectOptionDeprecated
128+
<SelectOption
126129
key={value}
127130
value={value}
128131
isSelected={selectedDataSource === value}
129132
isChecked={selectedDataSource === value}
130133
>
131134
<Badge key={value}>{type}</Badge>
132135
{` ${value}`}
133-
</SelectOptionDeprecated>
136+
</SelectOption>
134137
));
135138

136139
const selectDataSourcePlaceholder = (
@@ -141,23 +144,30 @@ const ComplexToolbarLogViewer = () => {
141144
);
142145

143146
const ControlButton = () => (
144-
<Button
145-
variant={isPaused ? 'plain' : 'link'}
146-
onClick={() => {
147-
setIsPaused(!isPaused);
148-
}}
149-
>
150-
{isPaused ? <PlayIcon /> : <PauseIcon />}
151-
{isPaused ? ` Resume Log` : ` Pause Log`}
152-
</Button>
153-
);
154-
147+
<Button
148+
variant={isPaused ? 'plain' : 'link'}
149+
onClick={() => {
150+
setIsPaused(!isPaused);
151+
}}
152+
>
153+
{isPaused ? <PlayIcon /> : <PauseIcon />}
154+
{isPaused ? ` Resume Log` : ` Pause Log`}
155+
</Button>
156+
);
157+
158+
const toggle = (toggleRef) => (
159+
<MenuToggle ref={toggleRef} onClick={onToggleClick} isExpanded={selectDataSourceOpen}>
160+
{selectDataSourcePlaceholder}
161+
</MenuToggle>
162+
);
163+
155164
const leftAlignedToolbarGroup = (
156165
<React.Fragment>
157166
<ToolbarToggleGroup toggleIcon={<EllipsisVIcon />} breakpoint="md">
158167
<ToolbarItem variant="search-filter">
159-
<SelectDeprecated
160-
onToggle={(_event, isOpen) => setSelectDataSourceOpen(isOpen)}
168+
<Select
169+
toggle={toggle}
170+
onOpenChange={(isOpen) => setSelectDataSourceOpen(isOpen)}
161171
onSelect={(event, selection) => {
162172
setSelectDataSourceOpen(false);
163173
setSelectedDataSource(selection);
@@ -172,10 +182,10 @@ const ComplexToolbarLogViewer = () => {
172182
placeholderText={selectDataSourcePlaceholder}
173183
>
174184
{selectDataSourceMenu}
175-
</SelectDeprecated>
185+
</Select>
176186
</ToolbarItem>
177187
<ToolbarItem variant="search-filter">
178-
<LogViewerSearch onFocus={_e => setIsPaused(true)} placeholder="Search" />
188+
<LogViewerSearch onFocus={(_e) => setIsPaused(true)} placeholder="Search" />
179189
</ToolbarItem>
180190
</ToolbarToggleGroup>
181191
<ToolbarItem>
@@ -206,7 +216,7 @@ const ComplexToolbarLogViewer = () => {
206216
);
207217

208218
const FooterButton = () => {
209-
const handleClick = _e => {
219+
const handleClick = (_e) => {
210220
setIsPaused(false);
211221
};
212222
return (
@@ -238,4 +248,4 @@ const ComplexToolbarLogViewer = () => {
238248
);
239249
};
240250

241-
export default ComplexToolbarLogViewer;
251+
export default ComplexToolbarLogViewer;

packages/module/patternfly-docs/content/extensions/react-log-viewer/demos/LogViewer.md

+11-12
Original file line numberDiff line numberDiff line change
@@ -7,19 +7,18 @@ source: react-demos
77
import { data } from '../examples/realTestData';
88
import { LogViewer, LogViewerSearch } from '@patternfly/react-log-viewer';
99
import {
10-
Badge,
11-
Button,
12-
Tooltip,
13-
Toolbar,
14-
ToolbarContent,
15-
ToolbarGroup,
16-
ToolbarItem,
17-
ToolbarToggleGroup
10+
Badge,
11+
Button,
12+
MenuToggle,
13+
Select,
14+
SelectOption,
15+
Tooltip,
16+
Toolbar,
17+
ToolbarContent,
18+
ToolbarGroup,
19+
ToolbarItem,
20+
ToolbarToggleGroup
1821
} from '@patternfly/react-core';
19-
import {
20-
Select as SelectDeprecated,
21-
SelectOption as SelectOptionDeprecated
22-
} from '@patternfly/react-core/deprecated';
2322
import OutlinedPlayCircleIcon from '@patternfly/react-icons/dist/esm/icons/outlined-play-circle-icon';
2423
import ExpandIcon from '@patternfly/react-icons/dist/esm/icons/expand-icon';
2524
import PauseIcon from '@patternfly/react-icons/dist/esm/icons/pause-icon';

0 commit comments

Comments
 (0)