Skip to content
This repository has been archived by the owner on May 1, 2020. It is now read-only.

Update docs on PHP Pattern States #85

Merged
merged 1 commit into from
Oct 10, 2017
Merged

Update docs on PHP Pattern States #85

merged 1 commit into from
Oct 10, 2017

Conversation

EvanLovely
Copy link
Member

I've made it so Pattern States in the PHP version are done just like the Node version with MD docs front matter over in this PR which is released in v2.8.3. The old behavior of [email protected] still works with the new approach taking precedence, so I'm not sure if we want to leave something in the docs or what. I'd say no as now PHP & JS has taken one step towards acting similar (not to mention that renaming files with @inprogress sucked.

/cc @bradfrost @bmuenzenmeyer

@bradfrost bradfrost merged commit 42441fe into master Oct 10, 2017
@bradfrost
Copy link
Member

@EvanLovely Fantastic! Thanks so much. This gets us closer to what we were talking about a bit ago with @bmuenzenmeyer to consolidate a lot of this stuff under the markdown files over file name conventions.

This as good a time as any to bring up documenting changes. How should we thinkg about current PL users who are using these conventions? Do the old conventions still work also? Should we update this page to talk about deprecating certain things? I'm sure there are conventions and presidents with all this stuff but I just wanted to flag it.

@bmuenzenmeyer bmuenzenmeyer deleted the php-pattern-states branch October 17, 2017 12:14
@bmuenzenmeyer
Copy link
Member

Thanks for doing this Evan - didn't even realize the preferred method was not on there. The documenting patterns page will need a lot of work, if it is meant to describe everything you can do with pattern markdown.

Should we update this page to talk about deprecating certain things? I'm sure there are conventions and presidents with all this stuff but I just wanted to flag it.

I am hesitant to update a single page with all relevant deprecations or additions, especially with two platforms each having their own release cycles. I think that's what release notes and changelogs are for

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants