Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate jQuery? #78

Open
bradfrost opened this issue Oct 5, 2017 · 5 comments
Open

Deprecate jQuery? #78

bradfrost opened this issue Oct 5, 2017 · 5 comments
Labels

Comments

@bradfrost
Copy link
Member

This is part of a larger effort refactoring of Pattern Lab's dependencies, but currently jQuery is being used intermittently throughout the codebase. This is more a question than anything, but is it possible to remove that jQuery dependency? My gut says yes, but it would be be great to get a more JS-savvy developer to review.

@bmuenzenmeyer
Copy link
Member

All of these FE dependencies have a jQuery reference. Not to say it's impossible - just trying to understand the footprint.

  • jwerty
  • jQueryCookie
  • typeahead

@sghoweri
Copy link

sghoweri commented Oct 8, 2017

Yeah... jQuery really shouldn't be needed given what the relatively simple JS requirements of Pattern Lab's Styleguidekit. There's plenty of options available w/o a jQuery dependency that should work just as good if not better!

@sghoweri
Copy link

sghoweri commented Oct 8, 2017

Alternatively, if the navigation was a vertical panel on the side with search at the very top OR if the nav items were horizontal (ala InVision's interface) we could always just combine fuzzy search with filtering the nav items that match up... http://listjs.com/examples/fuzzy-search/

@bradfrost
Copy link
Member Author

@sghoweri thanks for the roundup of non-jQuery options. I'd definitely be on board with migrating away from jQuery to complete those features.

Alternatively, if the navigation was a vertical panel on the side with search at the very top OR if the nav items were horizontal (ala InVision's interface) we could always just combine fuzzy search with filtering the nav items that match up... http://listjs.com/examples/fuzzy-search/

Interesting concept! Let's park that thought for now as I think there might be some other things we might do with search beyond just pattern navigation in the future. But love all these great ideas!

@bradfrost
Copy link
Member Author

TODO: turn these non-jQuery suggestions into actionable tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants