Keyboard shortcuts vs accesskeys

[ba55ie]

The keyboard shortcuts aren't working on my local installation (patternlab-node v2.3.0) and online. Tested with the latest Chrome and Firefox.

My suggestion is to use accesskeys instead of jwerty, because it will make the site more accessible and you can ditch the JS dependency.

https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/accesskey

[ba55ie]

Ah, according to the docs this feature is disabled, but it seems to be active in the code:

styleguidekit-assets-default/src/js/styleguide.js

Line 116 in 9935ac6

jwerty.key('ctrl+shift+s', function(e) {

[dmolsen]

@ba55ie -

Some of them are in there but not all. I'll look into accesskey as well. Thanks for the heads up.

[bradfrost]

I asked around about this: https://twitter.com/brad_frost/status/917429730630098951 and got some interesting results from a11y folks. It sounds like accesskeys can interfere with screen readers' built-in keyboard shortcuts. I'm going to ponder this a bit more, but in any case, I think moving to a non-jQuery version (referenced in #78) is a good idea.

[ba55ie]

OK, thanks for the heads up. Too bad that the usage of access keys still causes problems after so many years...