Refactor Chmod implementation to use UnixFileMode and remove Mono.Posix dependency #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jetersen
commented
Nov 8, 2024
| @@ -30,11 +30,10 @@ public void Should_Convert_Default_Permissions_To_Correct_File_Access_Permission | |||
| var result = chmod.ToFileAccessPermissions(); | |||
|
|
|||
| // Then | |||
| result.ShouldBe(FileAccessPermissions.DefaultPermissions); | |||
There was a problem hiding this comment.
DefaultPermissions does not exist on UnixFileMode also not relevant to the test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Environment.IsPrivilegedProcess calls IsPrivilegedProcessCore which calls
Interop.Sys.GetEUid() == 0on unixWe could properly use the same method for Windows although we are not checking if we are administrator, it checks if the token is elevated:
https://github.com/dotnet/runtime/blob/60b84bb13e499e0866731dbe21973b92b7abed15/src/libraries/System.Private.CoreLib/src/System/Environment.Windows.cs#L89-L115
The reason to remove this dependency is it carries around a libMonoPosixHelper.so/dylib/dll which is unnecessary for the functionality that we need. Which can be solved entirely in the BCL.
SetUnixFileModewas added in .NET 7