Fix crash on lock screen #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keeshux
added
bug
keeshux
added a commit
that referenced
this pull request
Oct 31, 2024
Set on the outmost root view. Also do not hardcode LogoView as lock view. Related to #779
keeshux
added a commit
that referenced
this pull request
Oct 31, 2024
#779 was happening because environment objects were set on contentView, which is not the _outmost_ root view. This clarifies why the Theme object was not being found in ThemeLockScreenModifier. Also, do not hardcode LogoView as lock view.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing environment Theme in LogoView.
Probably broken in #775