Skip to content

Commit

Permalink
Nightly Page: add an Android icon for Focus/Fenix/GeckoView bugs
Browse files Browse the repository at this point in the history
  • Loading branch information
pascalchevrel committed Jul 10, 2024
1 parent 309dcd6 commit 5237056
Show file tree
Hide file tree
Showing 4 changed files with 23 additions and 3 deletions.
2 changes: 1 addition & 1 deletion app/views/templates/base.html.twig
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<link rel="stylesheet" href="/assets/bootstrap/css/bootstrap.min.css" media="screen">
<link rel="stylesheet" href="/assets/bootstrap/css/bootstrap-icons.css" media="screen">
<link rel="stylesheet" href="/style/base.css?version=28" type="text/css" media="all" />
<link rel="stylesheet" href="/style/base.css?version=29" type="text/css" media="all" />
<link rel="icon" type="image/svg+xml" href="/assets/img/site_icon.svg" />
<link rel="apple-touch-icon" type="image/png" href="/assets/img/site_icon.png" />
<link rel="author" href="humans.txt" />
Expand Down
10 changes: 8 additions & 2 deletions app/views/templates/nightly.html.twig
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
<p>

</p>
<div class="collapse" id="collapse{{ dataset.buildid }}">
<div class="collapse" id="collapse{{ dataset.buildid }}">

<!-- Outstanding bugs -->
{% if outstanding_bugs[dataset.buildid].bugs %}
Expand Down Expand Up @@ -121,14 +121,20 @@
</thead>
<tbody>
{%- for details in bug_list[dataset.buildid].bugs -%}

{%- set alert_link = '' -%}
{%- set alert_title = '' -%}
{%- set alert_row = '' -%}
{%- set product = '' -%}

{%- set pill_level = 'text-bg-light border' -%}
{%- if details.type == 'enhancement' -%}
{%- set alert_link =' text-success fw-bold' -%}
{%- set alert_title =' title="Bug marked as Enhancement"' -%}
{%- endif -%}
{%- if details.product == 'Fenix' or details.product == 'GeckoView' or details.product == 'Focus' -%}
{%- set product = 'android' -%}
{%- endif -%}
{%- if bug_list_karma[details.id].score > 8 -%}
{%- set pill_level ='text-bg-warning' -%}
{%- endif -%}
Expand All @@ -140,7 +146,7 @@
{# do nothing #}
{% else %}
<tr class="small {{ alert_row }}">
<td><a href="https://bugzilla.mozilla.org/{{ details.id }}" class="text-end text-nowrap bug-link link-primary {{ alert_link }}" {{ alert_title|raw }}>{{ details.id }}</a></td>
<td class="{{ product }}"><a href="https://bugzilla.mozilla.org/{{ details.id }}" class="text-end text-nowrap bug-link link-primary {{ alert_link }}" {{ alert_title|raw }}>{{ details.id }}</a></td>
<td><a href="https://bugzilla.mozilla.org/{{ details.id }}" class="bug-link link-dark {{ alert_link }}">{{ details.component }}</td>
<td class="text-center {{ alert_row }}">
<span class="badge rounded-pill {{ pill_level }} score-pill">{{ bug_list_karma[details.id].score }}</span>
Expand Down
1 change: 1 addition & 0 deletions public/assets/img/android.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
13 changes: 13 additions & 0 deletions public/style/base.css
Original file line number Diff line number Diff line change
Expand Up @@ -303,3 +303,16 @@ footer {
margin-left:0.5em;
}

/* override Bootstrap striped styles as they don't allow background images */
#nightly table tr:nth-child(odd) td {
box-shadow: none !important;
background-color: #ecedee !important;
}

#nightly td.android {
background-image: url("/assets/img/android.svg");
background-repeat: no-repeat;
background-size: 1em;
background-position-x: 10px;
background-position-y: center;
}

0 comments on commit 5237056

Please sign in to comment.