Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to v4 artifacts #1223

Merged
merged 3 commits into from
Feb 6, 2025
Merged

Update to v4 artifacts #1223

merged 3 commits into from
Feb 6, 2025

Conversation

pdmullen
Copy link
Collaborator

@pdmullen pdmullen commented Feb 5, 2025 •
edited
Loading

PR Summary

PR Checklist

  • Code passes cpplint
  • New features are documented.
  • Adds a test for any bugs fixed. Adds tests for new features.
  • Code is formatted
  • Changes are summarized in CHANGELOG.md
  • Change is breaking (API, behavior, ...)
    • Change is additionally added to CHANGELOG.md in the breaking section
    • PR is marked as breaking
    • Short summary API changes at the top of the PR (plus optionally with an automated update/fix script)
  • CI has been triggered on Darwin for performance regression tests.
  • Docs build
  • (@lanl.gov employees) Update copyright on changed files

@pdmullen
Copy link
Collaborator Author

pdmullen commented Feb 5, 2025

Confirmed fails on v3

jdolence
jdolence approved these changes Feb 5, 2025
View reviewed changes
Copy link
Collaborator

@jdolence jdolence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Setting to automerge...

@jdolence jdolence enabled auto-merge February 5, 2025 21:04
lroberts36
lroberts36 approved these changes Feb 5, 2025
View reviewed changes
Copy link
Collaborator

@lroberts36 lroberts36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM if everything passes with v4. It was unclear to me if the changes in behavior going from v3 to v4 would impact our CI (see #1222).

@lroberts36 lroberts36 linked an issue Feb 5, 2025 that may be closed by this pull request
Update to artifact v4 for CI #1222
Closed
@lroberts36 lroberts36 disabled auto-merge February 6, 2025 01:34
@lroberts36 lroberts36 enabled auto-merge February 6, 2025 01:34
@lroberts36 lroberts36 merged commit 79240b9 into develop Feb 6, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yurlungur Yurlungur Yurlungur approved these changes

@jdolence jdolence jdolence approved these changes

@lroberts36 lroberts36 lroberts36 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to artifact v4 for CI
4 participants
@pdmullen @Yurlungur @jdolence @lroberts36