-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add beforeFind triggers for file #8700
base: alpha
Are you sure you want to change the base?
Conversation
I will reformat the title to use the proper commit message syntax. |
Thanks for opening this pull request! |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## alpha #8700 +/- ##
==========================================
- Coverage 94.37% 93.89% -0.48%
==========================================
Files 185 185
Lines 14761 14782 +21
==========================================
- Hits 13930 13880 -50
- Misses 831 902 +71
☔ View full report in Codecov by Sentry. |
Unfortunately, as browsers do not pass headers in when using an So, I think this implementation is a good start. |
@@ -3531,6 +3531,124 @@ describe('afterLogin hook', () => { | |||
}); | |||
|
|||
describe('saveFile hooks', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these test deliberately under the saveFile hooks
or should it be a new describe
section?
Pull Request
Issue
Currently, there are no find triggers for files.
Closes: #8241
Closes: #6572
Approach
Tasks