-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Use LRUCache for extendSessionOnUse
#8683
base: alpha
Are you sure you want to change the base?
Conversation
Thanks for opening this pull request! |
extendSessionOnUse
extendSessionOnUse
@Moumouls could you add your thoughts? |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## alpha #8683 +/- ##
==========================================
- Coverage 94.37% 94.19% -0.19%
==========================================
Files 185 185
Lines 14761 14758 -3
==========================================
- Hits 13931 13901 -30
- Misses 830 857 +27
☔ View full report in Codecov by Sentry. |
extendSessionOnUse
extendSessionOnUse
I will reformat the title to use the proper commit message syntax. |
extendSessionOnUse
extendSessionOnUse
Is this only a perf PR or does it actually fix a bug, or both - for the changelog entry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Bug and perf i think @mtrezza |
Then what would be a better PR title, to inform developers what the bug is. |
@dblythy Could you rewrite the PR title? If the PR includes a bug fix and a perf improvement, then the PR is a |
extendSessionOnUse
extendSessionOnUse
@Moumouls Do you think you could take a look at this Auth thing as well? We just need to resolve the conflict to merge this, but not sure how to do that. If you could make a suggestion I'd commit the change. |
Pull Request
Issue
Currently,
extendSessionOnUse
functions as a debounce, and does not clear thethrottle
store.Closes: #8682
Approach
Tasks