Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Migrate S3 Client from AWS SDK v2 to v3 #231

Merged
merged 61 commits into from
Jan 1, 2025

Conversation

mtrezza
Copy link
Member

@mtrezza mtrezza commented Jan 1, 2025

Continuation of #221 as it has been merged without breaking change note.

Closes: #197

Copy link

parse-github-assistant bot commented Jan 1, 2025

Thanks for opening this pull request!

Copy link

codecov bot commented Jan 1, 2025

Codecov Report

Attention: Patch coverage is 95.52239% with 3 lines in your changes missing coverage. Please review.

Project coverage is 97.18%. Comparing base (0e0d721) to head (9f8ab20).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
lib/optionsFromArguments.js 50.00% 2 Missing ⚠️
index.js 98.41% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #231      +/-   ##
==========================================
+ Coverage   95.60%   97.18%   +1.57%     
==========================================
  Files           2        2              
  Lines         205      213       +8     
  Branches       44        0      -44     
==========================================
+ Hits          196      207      +11     
+ Misses          9        6       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtrezza mtrezza changed the title feat: Migrate S3 Client from AWS SDK v2 (deprecated) to v3 feat: Migrate S3 Client from AWS SDK v2 to v3 Jan 1, 2025
@mtrezza mtrezza merged commit 8ac6014 into parse-community:master Jan 1, 2025
8 of 9 checks passed
parseplatformorg pushed a commit that referenced this pull request Jan 1, 2025
# [4.0.0](3.0.0...4.0.0) (2025-01-01)

### Features

* Migrate S3 Client from AWS SDK v2 to v3  ([#231](#231)) ([8ac6014](8ac6014))

### BREAKING CHANGES

* The AWS S3 credentials are now set under `s3overrides.credentials` instead of directly under the `s3overrides` key; see the [migration guide](https://github.com/parse-community/parse-server-s3-adapter?#migration-guide-from-3x-to-4x) for more details. ([8ac6014](8ac6014))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to AWS JS SDK v3 needed
3 participants