Skip to content

Conversation

Klapeyron
Copy link
Contributor

sp_application_crypto::AppPublic requires sp_core::crypto::Public:

/// Application-specific public key.
pub trait AppPublic: AppCrypto + Public + Debug + MaybeHash + Codec {
	/// The wrapped type which is just a plain instance of `Public`.
	type Generic: IsWrappedBy<Self> + Public + Debug + MaybeHash + Codec;
}

but it looks like similar requirement is missing for sp_application_crypto::AppSignature and sp_core::crypto::Signature:

/// Application-specific signature.
pub trait AppSignature: AppCrypto + Eq + PartialEq + Debug + Clone {
	/// The wrapped type which is just a plain instance of `Signature`.
	type Generic: IsWrappedBy<Self> + Eq + PartialEq + Debug;
}

This PR extends sp_application_crypto::AppSignature trait with sp_core::crypto::Signature.

@bkchr bkchr requested a review from a team September 5, 2025 16:30
@bkchr
Copy link
Member

bkchr commented Sep 5, 2025

/cmd prdoc --bump major

@bkchr bkchr added the T17-primitives Changes to primitives that are not covered by any other label. label Sep 5, 2025
Copy link
Contributor

github-actions bot commented Sep 5, 2025

Command "prdoc --bump major" has failed ❌! See logs here

@bkchr
Copy link
Member

bkchr commented Sep 5, 2025

/cmd prdoc --bump major --audience runtime_dev

Copy link
Contributor

github-actions bot commented Sep 5, 2025

Command "prdoc --bump major --audience runtime_dev" has failed ❌! See logs here

@michalkucharczyk michalkucharczyk requested a review from a team September 5, 2025 18:35
Copy link
Contributor

github-actions bot commented Sep 5, 2025

Review required! Latest push from author must always be reviewed

@Klapeyron Klapeyron force-pushed the extend_appsignature_trait branch from d8b3910 to b49aeb5 Compare September 5, 2025 19:52
@michalkucharczyk
Copy link
Contributor

michalkucharczyk commented Sep 6, 2025

@Klapeyron, in future, you can merge the origin/master into your branch and push it, instead of force pushing (which is not preferred). Thanks.

@Klapeyron
Copy link
Contributor Author

yea, I wanted to reduce number of commits, but it is making more issues xd

@bkchr bkchr enabled auto-merge September 8, 2025 06:58
@Klapeyron
Copy link
Contributor Author

Let me know if there’s anything I can do to help move this PR forward

@skunert
Copy link
Contributor

skunert commented Sep 11, 2025

@Klapeyron I think you need to do nothing. When you merge master, the approvals get reset because we need to review the newest commit (because you are first-time contributor). Please hold off, we will approve and merge.

@skunert skunert requested a review from a team September 11, 2025 07:21
@bkchr bkchr added this pull request to the merge queue Sep 11, 2025
Merged via the queue into paritytech:master with commit 1d4e9ec Sep 11, 2025
284 of 294 checks passed
@Klapeyron Klapeyron deleted the extend_appsignature_trait branch September 11, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T17-primitives Changes to primitives that are not covered by any other label.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants