-
Notifications
You must be signed in to change notification settings - Fork 1k
Extend AppSignature trait with Signature #9645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend AppSignature trait with Signature #9645
Conversation
/cmd prdoc --bump major |
Command "prdoc --bump major" has failed ❌! See logs here |
/cmd prdoc --bump major --audience runtime_dev |
Command "prdoc --bump major --audience runtime_dev" has failed ❌! See logs here |
23e2492
to
f3eea41
Compare
Review required! Latest push from author must always be reviewed |
d8b3910
to
b49aeb5
Compare
@Klapeyron, in future, you can merge the |
yea, I wanted to reduce number of commits, but it is making more issues xd |
Let me know if there’s anything I can do to help move this PR forward |
@Klapeyron I think you need to do nothing. When you merge master, the approvals get reset because we need to review the newest commit (because you are first-time contributor). Please hold off, we will approve and merge. |
1d4e9ec
sp_application_crypto::AppPublic requires sp_core::crypto::Public:
but it looks like similar requirement is missing for sp_application_crypto::AppSignature and sp_core::crypto::Signature:
This PR extends sp_application_crypto::AppSignature trait with sp_core::crypto::Signature.