Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Elastic Scaling Checks for FeatureIndex::ElasticScalingMVP #7286

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

EleisonC
Copy link

Description

This PR addresses issue #6352, which proposes cleaning up the codebase by assuming that the FeatureIndex::ElasticScalingMVP feature is always enabled.

Integration

  • Under the handle_active_leaves_update Set elastic_scaling_mvp to true (provisioner)
  • Under the construct_per_relay_parent_state Set inject_core_index to true (backing)

Review Notes

  • The inject_core_index flag is used to support elastic scaling. When true, the core index is injected into the BackedCandidate, enabling dynamic core allocation and deallocation.
  • I removed this check in the backing file since we assume elastic scaling is enabled.
node_features
    .get(FeatureIndex::ElasticScalingMVP as usize)
    .map(|b| *b)
    .unwrap_or(false);
  • I removed this check in the provisioner file since we assume elastic scaling is enabled.
request_node_features() 
if !elastic_scaling_mvp && core_count > 1 {
			continue
		}

@EleisonC
Copy link
Author

EleisonC commented Jan 21, 2025

Hey @sandreim. I have opened up this PR for the code refactor issue.
cc: @alindima

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant