Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate pallet-offences and pallet-offences-benchmarking to use umbrella crate #7213

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Migrate pallet-offences and pallet-offences-benchmarking to use umbrella crate #7213

wants to merge 10 commits into from
+57 −117

Conversation

Nathy-bajo
Copy link

Part of #6504

Polkadot Address: 121HJWZtD13GJQPD82oEj3gSeHqsRYm1mFgRALu4L96kfPD1

@Nathy-bajo Nathy-bajo requested a review from a team as a code owner January 16, 2025 23:08
@re-gius re-gius mentioned this pull request Jan 17, 2025
Open
92 tasks
@Nathy-bajo
Copy link
Author

please review @re-gius @bkchr

re-gius
re-gius reviewed Jan 21, 2025
View reviewed changes
substrate/frame/offences/Cargo.toml Outdated Show resolved Hide resolved
substrate/frame/offences/Cargo.toml Show resolved Hide resolved
@re-gius re-gius added R0-silent Changes should not be mentioned in any release notes T2-pallets This PR/Issue is related to a particular pallet. labels Jan 21, 2025
@paritytech-review-bot paritytech-review-bot bot requested a review from a team January 21, 2025 17:45
bkchr
bkchr reviewed Jan 21, 2025
View reviewed changes
substrate/frame/offences/benchmarking/src/mock.rs Outdated Show resolved Hide resolved
substrate/frame/offences/benchmarking/src/mock.rs Outdated Show resolved Hide resolved
substrate/frame/offences/src/tests.rs Outdated Show resolved Hide resolved
@paritytech-review-bot paritytech-review-bot bot requested a review from a team January 21, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@re-gius re-gius re-gius left review comments

@bkchr bkchr bkchr left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes T2-pallets This PR/Issue is related to a particular pallet.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nathy-bajo @bkchr @re-gius