Unify Import verifier usage across parachain template and omninode

[MrishoLukamba]

Closes #7055

@skunert @bkchr

[skunert]

Thanks for looking into this! The changes as proposed here cannot be merged. Let me expand on the context:

Context

The import queue used in the omni-node is shared across various chains, including our system chains (some of which are quite old). Historically, these chains followed a pattern where they would:

1. Start with relay-chain consensus (blocks 0 to X)
2. Later migrate to AURA consensus (blocks X+1 onwards)

The import queue needs to maintain backwards compatibility with these dual-consensus chains. When starting a fresh node, it begins downloading initial blocks that were authored with relay-chain consensus. The changes in this PR would cause these initial block imports to fail because we're exclusively using the AURA verifier. The verifier that was present before detects whether we have switched to AURA and then uses the required verifier.

Specific Changes Needed

The following verifier needs to be replaced:

polkadot-sdk/cumulus/polkadot-omni-node/lib/src/nodes/aura.rs

Line 123 in f7baa84

let aura_verifier = cumulus_client_consensus_aura::build_verifier::<

With this verifier:

polkadot-sdk/cumulus/client/consensus/aura/src/equivocation_import_queue.rs

Line 245 in f7baa84

let verifier = Verifier::<P, _, _, _> {

You may need to adjust the crate to make the second verifier publicly available.

The overall wrapping verifier should remain in place to handle path selection based on the consensus in use:

polkadot-sdk/cumulus/polkadot-omni-node/lib/src/nodes/aura.rs

Line 154 in f7baa84

let verifier = Verifier {

Apologies for not providing more info in the original issue!

[MrishoLukamba]

Thanks for looking into this! The changes as proposed here cannot be merged. Let me expand on the context:

Context

The import queue used in the omni-node is shared across various chains, including our system chains (some of which are quite old). Historically, these chains followed a pattern where they would:

1. Start with relay-chain consensus (blocks 0 to X)
2. Later migrate to AURA consensus (blocks X+1 onwards)

The import queue needs to maintain backwards compatibility with these dual-consensus chains. When starting a fresh node, it begins downloading initial blocks that were authored with relay-chain consensus. The changes in this PR would cause these initial block imports to fail because we're exclusively using the AURA verifier. The verifier that was present before detects whether we have switched to AURA and then uses the required verifier.

Specific Changes Needed

The following verifier needs to be replaced:

polkadot-sdk/cumulus/polkadot-omni-node/lib/src/nodes/aura.rs

Line 123 in f7baa84

let aura_verifier = cumulus_client_consensus_aura::build_verifier::<

With this verifier:

polkadot-sdk/cumulus/client/consensus/aura/src/equivocation_import_queue.rs

Line 245 in f7baa84

let verifier = Verifier::<P, _, _, _> {

You may need to adjust the crate to make the second verifier publicly available.

The overall wrapping verifier should remain in place to handle path selection based on the consensus in use:

polkadot-sdk/cumulus/polkadot-omni-node/lib/src/nodes/aura.rs

Line 154 in f7baa84

let verifier = Verifier {

Apologies for not providing more info in the original issue!

Okey on it

[MrishoLukamba]

@skunert done

[bkchr]

/cmd fmt

[github-actions]

Command "fmt" has started 🚀 See logs here

[github-actions]

Command "fmt" has finished ✅ See logs here

[MrishoLukamba]

/cmd fmt

done @bkchr @skunert

[skunert]

Looks Good!