Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable BEEFY report_fork_voting() #6732

Closed
wants to merge 8 commits into from
Closed

Enable BEEFY report_fork_voting() #6732

wants to merge 8 commits into from

Conversation

serban300
Copy link
Contributor

@serban300 serban300 commented Dec 2, 2024 •
edited
Loading

Related to #4523

Follow-up for: #5188

@serban300 serban300 added the T15-bridges This PR/Issue is related to bridges. label Dec 2, 2024
@serban300 serban300 self-assigned this Dec 2, 2024
@serban300 serban300 force-pushed the beefy-equivocation-runtime branch from f58d423 to 5c1c9e5 Compare December 2, 2024 14:55
@serban300
Copy link
Contributor Author

bot bench substrate-pallet --pallet=pallet_beefy_mmr
bot bench polkadot-pallet --pallet=pallet_beefy_mmr --runtime=rococo
bot bench polkadot-pallet --pallet=pallet_beefy_mmr --runtime=westend

@paritytech paritytech deleted a comment from command-bot bot Dec 2, 2024
@paritytech paritytech deleted a comment from command-bot bot Dec 2, 2024
@paritytech paritytech deleted a comment from command-bot bot Dec 2, 2024
@paritytech paritytech deleted a comment from command-bot bot Dec 2, 2024
@paritytech paritytech deleted a comment from command-bot bot Dec 2, 2024
@paritytech paritytech deleted a comment from command-bot bot Dec 2, 2024
@serban300
Copy link
Contributor Author

bot bench polkadot-pallet --pallet=pallet_beefy_mmr --runtime=rococo

@command-bot
Copy link

command-bot bot commented Dec 2, 2024 •
edited
Loading

@serban300 https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7850087 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=rococo --target_dir=polkadot --pallet=pallet_beefy_mmr. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 5-0d0bfc95-3ade-42f5-b09c-600f73f7fb78 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Dec 2, 2024

@serban300 Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=rococo --target_dir=polkadot --pallet=pallet_beefy_mmr has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7850087 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7850087/artifacts/download.

@serban300
Copy link
Contributor Author

bot bench polkadot-pallet --pallet=pallet_beefy_mmr --runtime=westend

@command-bot
Copy link

command-bot bot commented Dec 2, 2024 •
edited
Loading

@serban300 https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7850425 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=westend --target_dir=polkadot --pallet=pallet_beefy_mmr. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 6-ee38b68a-0826-4093-81e1-df539846b049 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Dec 2, 2024

@serban300 Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=westend --target_dir=polkadot --pallet=pallet_beefy_mmr has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7850425 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7850425/artifacts/download.

@serban300
Copy link
Contributor Author

bot bench substrate-pallet --pallet=pallet_beefy_mmr

@command-bot
Copy link

command-bot bot commented Dec 2, 2024 •
edited
Loading

@serban300 https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7850822 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --features=riscv --pallet=pallet_beefy_mmr. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 7-40577105-9ebe-4394-a46f-27b08ff13b81 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Dec 2, 2024

@serban300 Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --features=riscv --pallet=pallet_beefy_mmr has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7850822 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7850822/artifacts/download.

@serban300 serban300 force-pushed the beefy-equivocation-runtime branch from 677f60e to 7329fe9 Compare December 3, 2024 08:37
@serban300 serban300 mentioned this pull request Dec 3, 2024
Closed
3 tasks
@serban300 serban300 changed the title [Draft][WIP] Enable BEEFY report_fork_voting() Enable BEEFY report_fork_voting() Dec 3, 2024
@serban300 serban300 marked this pull request as ready for review December 3, 2024 08:43
@serban300 serban300 requested a review from acatangiu as a code owner December 3, 2024 08:43
@serban300 serban300 requested review from bkontur, acatangiu and a team and removed request for acatangiu December 3, 2024 08:43
acatangiu
acatangiu approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@acatangiu acatangiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Cargo.lock Show resolved Hide resolved
@serban300 serban300 closed this by deleting the head repository Dec 12, 2024
@acatangiu
Copy link
Contributor

@serban300 why close this?

@serban300
Copy link
Contributor Author

serban300 commented Dec 12, 2024 •
edited
Loading

Oops, I didn't want to close this. I deleted my fork of polkadot-sdk because I was getting some warning every day related to it. I will try to reopen it somehow.

@serban300 serban300 mentioned this pull request Dec 12, 2024
Merged
@serban300
Copy link
Contributor Author

Oops, I didn't want to close this. I deleted my fork of polkadot-sdk because I was getting some warning every day related to it. I will try to reopen it somehow.

Had to open a new PR: #6856

github-merge-queue bot pushed a commit that referenced this pull request Jan 22, 2025
@serban300
Enable BEEFY report_fork_voting() (#6856)
1bdb817 
Related to #4523

Follow-up for: #5188

Reopening #6732 as a new
PR

---------

Co-authored-by: command-bot <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acatangiu acatangiu acatangiu approved these changes

@bkontur bkontur Awaiting requested review from bkontur

Assignees

@serban300 serban300

Labels
T15-bridges This PR/Issue is related to bridges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@serban300 @acatangiu