Migrate pallet-aura to umbrella crate
#6622
Conversation
substrate/frame/aura/src/lib.rs
Outdated
| BoundedSlice, BoundedVec, ConsensusEngineId, Parameter, | ||
| use frame::{ | ||
| deps::{ | ||
| frame_support::{ConsensusEngineId, Parameter}, |
There was a problem hiding this comment.
Please read the new checklist named in the issue, and update the PR to adhere to it. Thank you!
re-gius
added
R0-silent
|
please review @kianenigma @re-gius |
substrate/frame/src/lib.rs
Outdated
| @@ -363,6 +366,9 @@ pub mod runtime { | |||
| /// Consider using the new version of this [`frame_construct_runtime`]. | |||
| pub use frame_support::construct_runtime; | |||
|
|
|||
| /// Related to runtime construction. | |||
There was a problem hiding this comment.
This comment is not relevant for me
substrate/frame/aura/src/lib.rs
Outdated
| BoundedSlice, BoundedVec, ConsensusEngineId, Parameter, | ||
| use frame::{ | ||
| runtime::prelude::*, | ||
| traits::{DisabledValidators, FindAuthor, IsMember, OnTimestampSet, OneSessionHandler}, |
There was a problem hiding this comment.
I would add IsMember to the main prelude of the umbrella crate
There was a problem hiding this comment.
Also moved OnTimestampSet to top level prelude, used in Babe and Aura pallets.
FindAuthor & DisableValidators to account mod
substrate/frame/aura/src/lib.rs
Outdated
| traits::{DisabledValidators, FindAuthor, Get, OnTimestampSet, OneSessionHandler}, | ||
| BoundedSlice, BoundedVec, ConsensusEngineId, Parameter, | ||
| use frame::{ | ||
| runtime::prelude::*, |
There was a problem hiding this comment.
Use the main prelude frame::prelude::* instead of the runtime one
substrate/frame/src/lib.rs
Outdated
| @@ -363,6 +366,9 @@ pub mod runtime { | |||
| /// Consider using the new version of this [`frame_construct_runtime`]. | |||
| pub use frame_support::construct_runtime; | |||
|
|
|||
| /// Related to runtime construction. | |||
| pub use frame_support::{BoundedSlice, BoundedVec}; | |||
There was a problem hiding this comment.
If you added them just to use the runtime prelude in the aura pallet, I think it's better to change it to the main prelude (see comment) and remove this from here
|
please pause work on migrating polkadot-sdk pallets to umbrella crate until we come to a final decision here: #6504 (comment) |
Part of #6504
Description
sp-application-cryptoin polkadot-sdk-frame crate, re-exportsRuntimeAppPublicandBoundToRuntimeAppPublicas part of the cryptography module.