Specifically target x86_64 for macos builds #9678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the beginning of this month, MacOS 14 became generally available in GitHub Actions. This means that the M1/Apple Silicon versions came out of beta, and (trickily for us) became the default image for
macos-latest.This switchover seems to have happened for us a few days ago in an entirely unrelated PR (I hope, it was mine 😅).
This means that our
macos-latestbuild is now spitting out arm64 bindings, as well as ouraarch64-apple-darwinbuild. Two Arms, no Intel.This means that the canary @parcel/rust package has been published without x64 bindings since v3197.
I've added a specific target for
x86_64-apple-darwinto ourmacos-latestbuild to force it back to outputting Intel binding.