Remember related files for Sass on syntax error #9315
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
When watching Sass files, an error from the Sass compiler will cause Parcel to no longer about which files a Sass entry file imports (i.e. which files will cause the entry file to be invalidated). This is documented in #7374 and #9292.
This PR remembers the previous invalidations and reapplies them to the input file in the case of an error.
Presumably this issue also affects other transformers (it's documented to also apply to Pug and Elm, at least), so perhaps this resolution is at the wrong level (maybe should be in
RequestTracker
?), but it does resolve the problem for Sass in the meantime.💻 Examples
See #9292
🚨 Test instructions
See #9292
✔️ PR Todo