Correctly handle empty resolver diagnostics array (#9407)

parcel-bundler · Mar 18, 2024 · 8cfc9c7 · 8cfc9c7
1 parent e9c1970
commit 8cfc9c7
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/packages/core/core/src/requests/PathRequest.js b/packages/core/core/src/requests/PathRequest.js
@@ -368,7 +368,13 @@ export class ResolverRunner {
             };
           }
 
-          if (result.diagnostics) {
+          if (
+            result.diagnostics != null &&
+            !(
+              Array.isArray(result.diagnostics) &&
+              result.diagnostics.length === 0
+            )
+          ) {
             let errorDiagnostic = errorToDiagnostic(
               new ThrowableDiagnostic({diagnostic: result.diagnostics}),
               {

diff --git a/packages/utils/node-resolver-core/src/Wrapper.js b/packages/utils/node-resolver-core/src/Wrapper.js
@@ -165,7 +165,7 @@ export default class NodeResolver {
           ? diagnostic
           : diagnostic
           ? [diagnostic]
-          : [],
+          : undefined,
         invalidateOnFileCreate: res.invalidateOnFileCreate,
         invalidateOnFileChange: res.invalidateOnFileChange,
       };