Fix FIPS selftest crash by pinning opencv-python-headless#96
Merged
Conversation
Replace bare `git lfs pull` (which downloads all LFS files including duplicate .bin weights) with sparse checkout + targeted LFS fetch. This prevents hanging on large models by excluding .bin/.gguf/.onnx files, adding progress output, retry logic, and concurrent transfer configuration. Falls back to .bin if no safetensors are found.
opencv-python-headless >=4.13 bundles a FIPS-enabled OpenSSL 1.1.1k from CentOS/RHEL. On FIPS-enabled HPC hosts (where Singularity exposes /proc/sys/crypto/fips_enabled=1), this bundled library triggers a fatal FIPS selftest failure at import time, crashing vllm serve. Pin to 4.12.0.88 which does not bundle OpenSSL. Also remove ineffective FIPS workarounds from both containers: - OPENSSL_CONF=/dev/null (targeted system OpenSSL 3.0.2, not the culprit) - OPENSSL_FORCE_FIPS_MODE=0 (not a real OpenSSL variable) - apt-get reinstall libssl-dev openssl (wrong library) - pip rebuild cryptography from source (unnecessary) Refs: opencv/opencv-python#1184 Refs: opencv/opencv-python#1191
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
opencv-python-headless >=4.13bundles a FIPS-enabled OpenSSL 1.1.1k from CentOS/RHEL. On FIPS-enabled HPC hosts, Singularity exposes the host's/proc/sys/crypto/fips_enabled=1, triggering a fatal FIPS selftest failure (crypto/fips/fips.c:154) when OpenCV is imported duringvllm serve.opencv-python-headless==4.12.0.88which does not bundle OpenSSL.OPENSSL_CONF=/dev/null,OPENSSL_FORCE_FIPS_MODE=0, reinstalling system OpenSSL, rebuilding cryptography from source) — none of these targeted the actual culprit.Refs: opencv/opencv-python#1184, opencv/opencv-python#1191
Test plan
vllm.siffrom updatedSingularity.vllmsingularity exec vllm.sif vllm serveon a FIPS-enabled host — should no longer crashsingularity exec vllm.sif python3 -c "import cv2; print(cv2.__version__)"— should print4.12.0.88rag.siffrom updatedSingularity.ragand verify it starts normally