Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for useParallel() #26

Merged
merged 6 commits into from
May 31, 2024
Merged

Add tests for useParallel() #26

merged 6 commits into from
May 31, 2024

Conversation

RickDT
Copy link
Contributor

@RickDT RickDT commented May 30, 2024 •
edited
Loading

Adds 3 tests to confirm that the useParallel() hook:

  1. Returns the expected shape
  2. Wraps a Promise around the getProfile() callback
  3. Includes the error message if getLoginStatus() results in an error.

@RickDT RickDT marked this pull request as ready for review May 30, 2024 22:25
@RickDT RickDT requested a review from bmuller May 30, 2024 22:25
bmuller
bmuller approved these changes May 31, 2024
View reviewed changes
Copy link
Member

@bmuller bmuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

Rick Terrill added 2 commits May 31, 2024 10:21
@RickDT RickDT merged commit 63f95c1 into master May 31, 2024
1 check passed
@RickDT RickDT deleted the rickterrill/sc-14950/add-tests-to-parallel-js-to-cover-the-useparallel branch May 31, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmuller bmuller bmuller approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RickDT @bmuller