Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TS types #23

Merged
merged 7 commits into from
Apr 26, 2024
Merged

Update TS types #23

merged 7 commits into from
Apr 26, 2024

Conversation

bmuller
Copy link
Member

@bmuller bmuller commented Apr 25, 2024 •
edited
Loading

This PR does a few things:

  1. Add missing types for the function getProfile in our vanilla package and additional login options for login
  2. Move the related getProfile types from the react package to the vanilla package
  3. Remove types for the (undocumented / unsupported) api function
  4. Ensure that pnpm build succeeds in our CI Github action

@bmuller bmuller requested a review from RickDT April 25, 2024 20:45
@bmuller bmuller merged commit d9de3f1 into master Apr 26, 2024
1 check passed
@bmuller bmuller deleted the bmuller/update-typescript-types branch April 26, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RickDT RickDT RickDT approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bmuller @RickDT