Improve lint and rollup configs

parallel-markets · Oct 4, 2023 · 34ba6d7 · 34ba6d7
1 parent 0d3b4ec
commit 34ba6d7
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/package.json b/package.json
@@ -5,7 +5,7 @@
   "description": "ParallelMarkets.com JavaScript SDK loading utility",
   "scripts": {
     "build": "pnpm --parallel --filter '@parallelmarkets/*' build",
-    "lint": "NODE_ENV=test eslint examples/*/src packages/*/src && prettier -l packages/*/src examples/*/src",
+    "lint": "eslint examples/*/src packages/*/src && prettier -l packages/*/src examples/*/src",
     "test": "NODE_ENV=test jest"
   },
   "keywords": [

diff --git a/packages/react/rollup.config.mjs b/packages/react/rollup.config.mjs
@@ -8,6 +8,7 @@ const config = [
   {
     input: 'src/index.tsx',
     output: { file: pkg.main, format: 'cjs', generatedCode: 'es5' },
+    external: ['react'],
     plugins: [
       image(),
       // run TS first
@@ -23,6 +24,7 @@ const config = [
   {
     input: 'src/index.tsx',
     output: { file: pkg.module, format: 'esm', generatedCode: 'es2015' },
+    external: ['react'],
     plugins: [
       image(),
       // Run TS

diff --git a/packages/vanilla/package.json b/packages/vanilla/package.json
@@ -28,7 +28,7 @@
   ],
   "scripts": {
     "build": "NODE_ENV=production rollup -c",
-    "lint": "NODE_ENV=test eslint ./src && prettier -l ./src",
+    "lint": "eslint ./src && prettier -l ./src",
     "test": "NODE_ENV=test jest",
     "typecheck": "tsc --noEmit",
     "watch": "pnpm typecheck --watch --noEmit"