Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade npm deps, GHA, and runtime. Enable minification. #6

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Upgrade npm deps, GHA, and runtime. Enable minification. #6

merged 2 commits into from
Oct 17, 2023

Conversation

pavelloz
Copy link
Contributor

@pavelloz pavelloz commented Oct 16, 2023 •
edited
Loading

This PR upgrades node, npm dependencies, GHA actions used to build the action, and enables minification.

Minification results

Before

  40kB  dist/sourcemap-register.js
3319kB  dist/index.js
6875kB  [1928ms] - ncc 0.38.0

After:

  40kB  dist/sourcemap-register.js
1720kB  dist/index.js
6112kB  [3156ms] - ncc 0.38.0

@pavelloz pavelloz changed the title Upgrade npm dependencies and GHA Upgrade npm deps, GHA, and runtime. Enable minification. Oct 16, 2023
@bmuller
Copy link
Member

bmuller commented Oct 16, 2023

@pavelloz should we add a .tool-versions file to align on node version? I think that may be a good idea because when I run pnpm prepare I get slightly different dist files.

@pavelloz
Copy link
Contributor Author

@bmuller yes, i did the upgrade and version pinning in d31aa1e

@pavelloz pavelloz merged commit f93250d into master Oct 17, 2023
4 checks passed
@pavelloz pavelloz deleted the pavel/update branch October 17, 2023 14:33
pavelloz added a commit that referenced this pull request Oct 17, 2023
@pavelloz
Revert "Upgrade npm deps, GHA, and runtime. Enable minification. (#6)"
475f17f 
This reverts commit f93250d.
pavelloz added a commit that referenced this pull request Oct 17, 2023
@pavelloz
Revert october updates (#9)
10a5691 
* Revert "Update to node 20 (#7)"

This reverts commit 7fb4e2c.

* Revert "Upgrade npm deps, GHA, and runtime. Enable minification. (#6)"

This reverts commit f93250d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florensvb florensvb florensvb approved these changes

@bmuller bmuller bmuller approved these changes

@nonrational nonrational Awaiting requested review from nonrational nonrational is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pavelloz @bmuller @florensvb