Use process.exit() to mitigate actions/toolkit#1578 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artkay
approved these changes
Feb 27, 2024
bmuller
approved these changes
Feb 27, 2024
marchdoe
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
h/t @pavelloz for calling out that our builds had gained an extra 2m-3m runtime since we released v2 on node20. Looks like there's an open issue with GHA that causes node20 processes to hang before exiting.
This PR uses
process.exit()(as some others have done) to force the action to exit after it's done its work.After this merges, I will tag as
v2.0.1andv2and our workflows that use this action will get 2-3m faster.