refactor(optimism): Extract pending block building responsibility out of FlashBlockService
#18247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of `FlashBlockService`
RomanHodulak
requested review from
mattsse,
Rjected and
fgimenez
as code owners
RomanHodulak
force-pushed
the
reth-optimism-flashblocks28
branch
3 times, most recently
from
9e62637 to
bd9491c
Compare
mattsse
requested changes
Sep 5, 2025
There was a problem hiding this comment.
cool, extracting this logic makes a lot of sense,
what's still missing now actually spawn the .execute part blocking and send back the response through a channel the we poll in the service together with the cached reads
there's some additional movement in progress with these files so we can hold off here a bit and get perhaps get #18272 and #18276 in first?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #17858
Towards #18219
The
FlashBlockServicehas too many responsibilities and it's becoming too tangled up. Moreover, to spawn blocking tasks for block building we're going to need an independent unit that performs only these jobs.