-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enhance explain #146
Conversation
It depends on sqlparser apache/datafusion-sqlparser-rs#1426. Awaiting the next release of the library. |
Should this be based off of #140? |
c6f38a0
to
cc4262f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please provide output examples for all the style/options you are adding here? I.e. what the query looks like, and what the output looks like? I'd like to build a better understanding of what this will look like before we merge anything.
Also some tests, but I understand this PR isn't ready for review yet.
That looks really great. I think we should totally add this STYLE option :). Great idea! |
cc4262f
to
6ac9bc9
Compare
@kysshsy Thank YOU for finishing this! It looks GREAT. Just the Clippy and will be good |
6ac9bc9
to
b8b85c8
Compare
fixed. :) |
Thank you for making this!! |
Ticket(s) Closed
EXPLAIN
Statement: Addanalyze
option, Supportstyle
option #124What
Why
How
Support the ANALYZE option: add a timer to record the actual execution time.
Support the STYLE option: Provide the query plan and execution time in DuckDB style.
Tests