fix: defer decryption after tag verification passes

panva · Jul 17, 2021 · 0795a87 · 0795a87
1 parent 6df5375
commit 0795a87
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/lib/help/crypto_worker.js b/lib/help/crypto_worker.js
@@ -128,11 +128,9 @@ if (isMainThread) {
       const preAuth = pae('v1.local.', n, c, f)
 
       const t2 = methods.hmac('sha384', preAuth, ak)
+      if (!timingSafeEqual(t, t2)) return false
       const payload = methods.decrypt('aes-256-ctr', c, ek, n.slice(16))
-
-      if (!timingSafeEqual(t, t2) || !payload) {
-        return false
-      }
+      if (!payload) return false
 
       return payload
     },