Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the docs to be under
/docs
, rather than at the top level. For example:Prose docs:
Reference docs:
This is mostly to fix #7 by working around facebook/docusaurus#9688. With this change, a URL like https://docs.pantsbuild.org/abc/xyz shows the 404 content. That said, is arguably nice to have everything in a defined little box (i.e. we've got a
/blog
box, a/community
box, and now a/docs
box).This does have the downside of making URLs longer and somewhat repetitive, but it seems fine. 🤷♂️ If we hated the repetition we could choose different words (like
/docs/2.18/guides/...
for prose docs) or "silly" tricks with URLs, like/v/2.18/docs/...
to be read likev2.18
(this doesn't work so well if we choose to also do unversioned URLs in future).Thoughts?