Prepare 2.25.0.dev3 #21794
Closed
Prepare 2.25.0.dev3 #21794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* After 1.0 releases will not be done on master so this will never match
Remove the check for master * After 1.0 releases will not be done on master so this will never match Testing Done: CI pending: https://travis-ci.org/pantsbuild/pants/builds/125161498 Did local dry-run of release script Bugs closed: 3252 Reviewed at https://rbcommons.com/s/twitter/r/3745/
Testing Done: None! I don't know how to test it. I just specify a pants version in pants.ini; I don't know how to specify a custom version that I'm running locally since I'm not a pants developer, just someone who is trying to fix a tool I'm using so I can upgrade to a newer version. I DO know that groups() returns strings (see _find_meta_tag()) and that there is no such method as starts_with() in Python for String/Unicode classes. The correct method is startswith(): https://docs.python.org/2/library/stdtypes.html#str.startswith Given that this code is currently broken as-is, it does not become more broken with this change. Reviewed at https://rbcommons.com/s/twitter/r/3744/
…with dashes in goal names Testing Done: Travis CI: https://travis-ci.org/pantsbuild/pants/builds/125623447 This is the only goal name that uses underscores instead of dashes in the goal name. This change makes all the goal names consistent ``` ./pants goals Installed goals: apk: Build an android bundle with compiled code and assets. bash-completion: Generate a Bash shell script that teaches Bash how to autocomplete pants command lines. bench: Run benchmarks. binary: Create a runnable binary. bootstrap: Bootstrap tools needed by subsequent build steps. buildgen: Automatically generate BUILD files. bundle: Create a deployable application bundle. changed: Emits the targets that have been modified since a given commit. check_published_deps: Find references to outdated JVM artifacts. clean-all: Delete all build products, creating a clean workspace. cloc: Print counts of lines of code. compile: Compile source code. compile-changed: Find and compile changed targets. deferred-sources: Map DeferredSourcesFields to files that produce the product 'unpacked_archives'. dep-usage: Collect target dependency usage data. dependees: List all targets that depend on any of the input targets. dependencies: Print the target's dependencies. depmap: Depict the target's dependencies. detect-duplicates: Detect JVM classes and resources with the same qualified name on the classpath. doc: Generate documentation. eclipse: Create an Eclipse project from the given targets. ensime: Create an Ensime project from the given targets. export: Export project information in JSON format. export-classpath: Create stable symlinks for runtime classpath entries for JVM targets. filedeps: List all source and BUILD files a target transitively depends on. filemap: Print a mapping from source file to the target that owns the source file. filter: Filter the input targets based on various criteria. gen: Generate code. go: Runs an arbitrary go command against zero or more go targets. go-env: Runs an arbitrary command in a go workspace defined by zero or more go targets. goals: List available goals. idea: Create an IntelliJ IDEA project from the given targets. imports: Resolve external source dependencies. invalidate: Invalidate the entire build. jar: Create a JAR file. jvm-platform-explain: Console task which provides helpful analysis about jvm platform dependencies. jvm-platform-validate: Validation step that runs well in advance of jvm compile. kill-pantsd: Terminate the pants daemon. killserver: Kill the reporting server. list: Lists all targets matching the target specs. list-owners: Print targets that own a source file. markdown: Generate HTML from Markdown docs. minimize: Print a minimal covering set of targets. ng-killall: Kill running nailgun servers. options: Display meta-information about options. path: Find a dependency path from one target to another. pathdeps: List all paths containing BUILD files the target depends on. paths: List all dependency paths from one target to another. publish: Publish a build artifact. reference: Generate Pants reference documentation. repl: Run a REPL. repl-dirty: Run a REPL, skipping compilation. resolve: Resolve external binary dependencies. resources: Prepare resources. roots: List the repo's registered source roots. run: Invoke a binary. run-dirty: Invoke a binary, skipping compilation. server: Run the reporting server. setup-py: Generate setup.py-based Python projects. sign: Sign Android packages with keystores using the jarsigner tool. sitegen: Generate the Pants static web site. sort: Topologically sort the targets. targets: List available target types. test: Run tests. test-changed: Find and test changed targets. thrift-linter: Print linter warnings for thrift files. unpack-jars: Unpack artifacts specified by unpacked_jars() targets. ``` Bugs closed: 3259 Reviewed at https://rbcommons.com/s/twitter/r/3749/
Apply fixes for problems found in 1.0.0-rc2 Cherry pick changes: https://rbcommons.com/s/twitter/r/3749/ https://rbcommons.com/s/twitter/r/3744/ Testing Done: CI pending: https://travis-ci.org/pantsbuild/pants/builds/125887760 Bugs closed: 3268 Reviewed at https://rbcommons.com/s/twitter/r/3757/
First major release for pantsbuild/pants. * bump version number from RC3 Testing Done: ran dry-run release. https://travis-ci.org/pantsbuild/pants/builds/126711956 Bugs closed: 3300 Reviewed at https://rbcommons.com/s/twitter/r/3785/
The current implementation will raise an error if a list option provided using the extend syntax ends with a double quote. This adds code to handle that case. Testing Done: Wrote regression tests in the unit test suite. Saw them fail. Made them pass. CI away in the PR (3327). Bugs closed: 3304, 3327 Reviewed at https://rbcommons.com/s/twitter/r/3813/ closes #3304, closes #3327
Currently addresses return NotImplemented when other is not an instance of Address. That's fine, but `__ne__` calls `__eq__` without checking for `NotImplemented`, which is truthy, so `address != not_an_address` will return False. This changes `__eq__` to return False instead, and adds a regression assertion. It also updates `__ne__` so that it uses the operator so that it can't propagate `NotImplemented` even if it might otherwise have been propagated. Testing Done: Ran address tests locally, CI away in PR. Bugs closed: 3306 Reviewed at https://rbcommons.com/s/twitter/r/3791/ Closes #3306
The current behavior is that we re-resolve the scrooge dependencies for each thrift target. This changes scrooge gen so that only the first target created does a resolve and afterwards it is cached. Testing Done: CI away on PR. Local testing against code gen targets. Bugs closed: 3305 Reviewed at https://rbcommons.com/s/twitter/r/3790/ closes #3305
I was doing some profiling of noop runs and noticed this linear search showing up fairly high when building targets with a closure of around 7k targets. This creates a set and uses that as a look up table rather than retraversing the list for each target. Testing Done: CI passed at https://travis-ci.org/pantsbuild/pants/builds/126737381 Bugs closed: 3302 Reviewed at https://rbcommons.com/s/twitter/r/3786/ closes #3302
Release notes are here: https://pypi.python.org/pypi/pex/1.1.6 Testing Done: CI went green here: https://travis-ci.org/pantsbuild/pants/builds/126011923 Bugs closed: 3279 Reviewed at https://rbcommons.com/s/twitter/r/3768/
These attributes were introduced in https://rbcommons.com/s/twitter/r/3582/ Testing Done: Updated unit tests, added integration test CI build: https://travis-ci.org/pantsbuild/pants/builds/129422787 Bugs closed: 3386, 3396 Reviewed at https://rbcommons.com/s/twitter/r/3845/
This review splits the release notes by release branch (ie, `master` for pre releases, `1.0.x` for stable releases). This change is related-but-mostly-orthogonal-to https://rbcommons.com/s/twitter/r/3890/ , in that it uses all of the same terminology, but can land independently. - Split release notes by release branch, with a top-level link for each release. - Preserve the CHANGELOG.rst entry in order to act as a branching off point for per-branch notes. - Add a (pantsbuild/pants private) Subsystem to allow configuring the location of notes for each branch. - Fix the `long_description` fetching code in `pants-plugins/src/python/internal_backend/utilities/register.py` to fetch from the relevant notes file for the current version. Testing Done: Deployed here: http://pantsbuild.github.io/staging/stuhood-release-notes-per-branch/index.html https://travis-ci.org/pantsbuild/pants/builds/131493908 Bugs closed: 2639, 3468 Reviewed at https://rbcommons.com/s/twitter/r/3907/
Our remote artifact cache serves over HTTPS, which the RESTful artifact cache ostensibly supports, but the Pinger was previously checking what URLs are reachable using only HTTP. This change switches pinger to use requests instead of httplib, which gives us HTTPS support "for-free". Testing Done: Added test to pinger.py. All tests in pinger.py pass locally. Jenkins went green: http://jenkins.pantsbuild.org/job/pantsbuild/job/pants/branch/PR-3463/5/ Bugs closed: 3463 Reviewed at https://rbcommons.com/s/twitter/r/3904/
It currently fails to find owners because the most recent release was a `pre` release. Testing Done: successfully executed a release. ---- http://jenkins.pantsbuild.org/job/pantsbuild/job/pants/branch/PR-3464/ Bugs closed: 3464 Reviewed at https://rbcommons.com/s/twitter/r/3903/
Add notes for 1.0.1. Will be committed to master, and cherry-picked to stable `1.0.x` (along with a version bump). Testing Done: http://jenkins.pantsbuild.org/job/pantsbuild/job/pants/branch/PR-3533/1/ Bugs closed: 3533 Reviewed at https://rbcommons.com/s/twitter/r/3960/
During the `1.0.1-rc0` release, running the release script in the stable branch re-published the docsite in its pre-`1.0.0` form. This review makes that step of the release script conditional on being on master. - Update the release script to only publish the docsite from master - (somewhat unrelated) Update docs to mention committing notes to both locations Testing Done: https://travis-ci.org/pantsbuild/pants/builds/134044116 Bugs closed: 3491, 3530 Reviewed at https://rbcommons.com/s/twitter/r/3956/
huonw
added
automation:release-prep
|
This looks highly incorrect (for some reason it's branched off 1.0.x), trying again... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.