Add Trivy security scanner #21780
Open
Add Trivy security scanner #21780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(previously it was escaping the sandbox to use /tmp/trivy, which won't survive reboots)
When running on a module, `get_terraform_backend_and_vars` would detect all vars files. (Because the vars files are typically specified as dependencies on the deployment, the module has none. Inference then grabs all of them.) This is almost certainly not desired, especially since they will be passed when running against the deployment.
# This is the 1st commit message: document using Trivy in all backends # The commit message pantsbuild#2 will be skipped: # fixup! docs
lilatomic
added
category:new feature
backend: Docker
lilatomic
added
backend: Helm
alonsodomin
reviewed
Dec 19, 2024
There was a problem hiding this comment.
LGMT
Just an observation on how other tools have been added in the past, the default approach I believe is to add their register.py hook under the experimental package, even when the parent module has already been graduated.
Taking as a reference the Python backend and its extra tools that have been gradually added but I'll let others have the final word on that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trivy is a scanner for finding security vulnerabilities and misconfigurations in Docker images, Helm charts, and Terraform modules (among others). This MR adds it for all of those.
I made it as a single MR to minimise churn in the common code (like the invocation of Trivy). Let me know if you'd rather I split this up.