-
-
Notifications
You must be signed in to change notification settings - Fork 643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update openDAL to latest version #21779
base: main
Are you sure you want to change the base?
Conversation
0.44.2 should fix the GHAC AWS S3 errors I'm seeing, but might as well try updating to the latest release version for now
I don't really know anything about rust development, so I'd appreciate guidance on if there is anything else that needs to be done in tandem with just changing the version number |
Thanks for this, and thanks for diving into unfamiliar territory! This looks like it's along the right lines, but we'll need some adjustments:
Other than that, I don't think anything else is required. |
Thanks for the quick review. I've made the requested updates. |
I see there are some build failures. Looks like the opendal upgrade does involve a few breaking changes. I'm going to be a bit busy with the holidays, but will circle back to this when I've got some time in front of me. |
Thank you! It looks like there's been some changes to the OpenDAL APIs that break compilation. Unfortunately, it seems like their changelog doesn't call out the changes very clearly so it's a bit of fuss to resolve them. If you're new to Rust, I suspect it won't be a fun time to work through. Are you okay if I push to this PR @DLukeNelson ? |
0.44.2 should fix the GHAC AWS S3 errors I'm seeing, but might as well try updating to the latest release version for now