Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update openDAL to latest version #21779

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

DLukeNelson
Copy link

0.44.2 should fix the GHAC AWS S3 errors I'm seeing, but might as well try updating to the latest release version for now

0.44.2 should fix the GHAC AWS S3 errors I'm seeing, but might as well try updating to the latest release version for now
@DLukeNelson
Copy link
Author

I don't really know anything about rust development, so I'd appreciate guidance on if there is anything else that needs to be done in tandem with just changing the version number

@huonw
Copy link
Contributor

huonw commented Dec 18, 2024

Thanks for this, and thanks for diving into unfamiliar territory! This looks like it's along the right lines, but we'll need some adjustments:

  • release notes: can you add a brief paragraph to docs/notes/2.25.x.md, in the Remote Caching/Execution section? E.g. "The OpenDAL library powering the Github Actions cache backend has been updated, picking up some bug fixes for ..."
  • reduced updates: it looks like this updates a lot of packages: it's really easy to do this by writing ./cargo update which updates the world to their latest compatible versions. It'd be good to only update what's required here to reduce the scope. Could you revert the Cargo.lock change and then run ./cargo update opendal to constrain the update to just the required packages?

Other than that, I don't think anything else is required.

@DLukeNelson
Copy link
Author

Thanks for the quick review. I've made the requested updates.

@DLukeNelson
Copy link
Author

I see there are some build failures. Looks like the opendal upgrade does involve a few breaking changes. I'm going to be a bit busy with the holidays, but will circle back to this when I've got some time in front of me.

@huonw
Copy link
Contributor

huonw commented Dec 19, 2024

Thank you! It looks like there's been some changes to the OpenDAL APIs that break compilation. Unfortunately, it seems like their changelog doesn't call out the changes very clearly so it's a bit of fuss to resolve them.

If you're new to Rust, I suspect it won't be a fun time to work through. Are you okay if I push to this PR @DLukeNelson ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants