Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the legacy CLI Alias code. #21743

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Remove the legacy CLI Alias code. #21743

merged 1 commit into from
Dec 11, 2024

Conversation

benjyw
Copy link
Contributor

@benjyw benjyw commented Dec 11, 2024

It has been reimplemented in Rust.

@benjyw benjyw added the category:internal CI, fixes for not-yet-released features, etc. label Dec 11, 2024
@benjyw benjyw requested review from kaos and huonw December 11, 2024 17:39
huonw
huonw approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@huonw huonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

@benjyw
Copy link
Contributor Author

benjyw commented Dec 11, 2024

🫡 to @kaos's excellent original code, which was so clearly written that porting it to Rust was straightforward.

@benjyw benjyw merged commit 80b21b7 into pantsbuild:main Dec 11, 2024
24 checks passed
@benjyw benjyw deleted the remove_legacy_cli_alias_code branch December 11, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huonw huonw huonw approved these changes

@kaos kaos Awaiting requested review from kaos

Assignees
No one assigned
Labels
category:internal CI, fixes for not-yet-released features, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benjyw @huonw