Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable proto3 optional to enable engine builds for Ubuntu 22.04 #21734

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enable proto3 optional to enable engine builds for Ubuntu 22.04 #21734

wants to merge 1 commit into from

Conversation

tobni
Copy link
Contributor

@tobni tobni commented Dec 8, 2024

Enabled as a default for protoc 3.15, but current apt package dist for ubuntu 22.04 LTS (my system) is 3.12.

@tobni
build: Enable proto3 optional
1d87862 
Enabled as a default for 3.15, but current apt package is 3.12
@tobni tobni added the category:internal CI, fixes for not-yet-released features, etc. label Dec 8, 2024
huonw
huonw approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@huonw huonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

I assume passing this arg on newer versions of protoc (where it's on by default) doesn't affect behaviour/is a noop?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huonw huonw huonw approved these changes

Assignees
No one assigned
Labels
category:internal CI, fixes for not-yet-released features, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobni @huonw