Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow unesecure node temporarily for manylinux container builds #21172

Merged
merged 3 commits into from
Jul 15, 2024
Merged

Allow unesecure node temporarily for manylinux container builds #21172

merged 3 commits into from
Jul 15, 2024

Conversation

tobni
Copy link
Contributor

@tobni tobni commented Jul 14, 2024 •
edited
Loading

Renders github actions and env settings to continue to use node16 inside the containers that match the glibc (2.17) of manylinux_2014 builder images. The new default node version for gha requires a much higher version.

I checked if https://github.com/nodejs/unofficial-builds had node binaries we could use. It does not.

Based on #21133

@tobni tobni added category:internal CI, fixes for not-yet-released features, etc. release-notes:not-required PR doesn't require mention in release notes labels Jul 14, 2024
@tobni tobni mentioned this pull request Jul 14, 2024
Merged
@tobni tobni requested a review from benjyw July 14, 2024 19:05
@tobni
Copy link
Contributor Author

tobni commented Jul 14, 2024

Successful (but filled with warnings, none seem dangerous though) run: https://github.com/pantsbuild/pants/actions/runs/9929989447

@tobni tobni force-pushed the fix/allow-unesecure-node-temporarily branch from ac42bf1 to 9c8c88e Compare July 14, 2024 19:22
benjyw
benjyw approved these changes Jul 14, 2024
View reviewed changes
Copy link
Contributor

@benjyw benjyw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing! LG mod an error message nit.

src/python/pants_release/generate_github_workflows.py Outdated Show resolved Hide resolved
src/python/pants_release/generate_github_workflows.py Outdated Show resolved Hide resolved
@tobni tobni force-pushed the fix/allow-unesecure-node-temporarily branch from 20cec3e to acdba74 Compare July 15, 2024 12:47
@tobni tobni enabled auto-merge (squash) July 15, 2024 12:48
@tobni
Copy link
Contributor Author

tobni commented Jul 15, 2024

@benjyw Added a more helpful exception and rebased on upstream after merging #21133

@tobni tobni merged commit 7452afe into main Jul 15, 2024
25 checks passed
@tobni tobni deleted the fix/allow-unesecure-node-temporarily branch July 15, 2024 13:05
tobni added a commit to tobni/pants that referenced this pull request Jul 22, 2024
@tobni
Allow unesecure node temporarily for manylinux container builds (pant…
6678bc0 
…sbuild#21172)

Renders github actions and env settings to continue to use node16 inside
the containers that match the glibc (2.17) of manylinux_2014 builder
images. The new default node version for gha requires a much higher
version.

I checked if https://github.com/nodejs/unofficial-builds had node
binaries we could use. It does not.

Based on pantsbuild#21133
@huonw huonw mentioned this pull request Jul 24, 2024
Open
@huonw huonw added this to the 2.20.x milestone Jul 24, 2024
@WorkerPants
Copy link
Member

I tried to automatically cherry-pick this change back to each relevant milestone, so that it is available in those older releases of Pants.

❌ 2.20.x

I was unable to cherry-pick this PR to 2.20.x, likely due to merge-conflicts.

Steps to Cherry-Pick locally

To resolve:

  1. (Ensure your git working directory is clean)
  2. Run the following script to reproduce the merge-conflicts: 
    git fetch https://github.com/pantsbuild/pants main \
  && git fetch https://github.com/pantsbuild/pants 2.20.x \
  && git checkout -b cherry-pick-21172-to-2.20.x FETCH_HEAD \
  && git cherry-pick 7452afeed46bc4a26c1ed0fe5508d669fb3d7985
  3. Fix the merge conflicts and commit the changes
  4. Run build-support/cherry_pick/make_pr.sh "21172" "2.20.x"

Please note that I cannot re-run CI if a job fails. Please work with your PR approver(s) to re-run CI if necessary.

❌ 2.21.x

I was unable to cherry-pick this PR to 2.21.x, likely due to merge-conflicts.

Steps to Cherry-Pick locally

To resolve:

  1. (Ensure your git working directory is clean)
  2. Run the following script to reproduce the merge-conflicts: 
    git fetch https://github.com/pantsbuild/pants main \
  && git fetch https://github.com/pantsbuild/pants 2.21.x \
  && git checkout -b cherry-pick-21172-to-2.21.x FETCH_HEAD \
  && git cherry-pick 7452afeed46bc4a26c1ed0fe5508d669fb3d7985
  3. Fix the merge conflicts and commit the changes
  4. Run build-support/cherry_pick/make_pr.sh "21172" "2.21.x"

Please note that I cannot re-run CI if a job fails. Please work with your PR approver(s) to re-run CI if necessary.

❌ 2.22.x

I was unable to cherry-pick this PR to 2.22.x, likely due to merge-conflicts.

Steps to Cherry-Pick locally

To resolve:

  1. (Ensure your git working directory is clean)
  2. Run the following script to reproduce the merge-conflicts: 
    git fetch https://github.com/pantsbuild/pants main \
  && git fetch https://github.com/pantsbuild/pants 2.22.x \
  && git checkout -b cherry-pick-21172-to-2.22.x FETCH_HEAD \
  && git cherry-pick 7452afeed46bc4a26c1ed0fe5508d669fb3d7985
  3. Fix the merge conflicts and commit the changes
  4. Run build-support/cherry_pick/make_pr.sh "21172" "2.22.x"

Please note that I cannot re-run CI if a job fails. Please work with your PR approver(s) to re-run CI if necessary.

When you're done manually cherry-picking, please remove the needs-cherrypick label on this PR.

Thanks again for your contributions!

🤖 Beep Boop here's my run link

@WorkerPants WorkerPants added the auto-cherry-picking-failed Auto Cherry-Picking Failed label Jul 24, 2024
@huonw
Copy link
Contributor

huonw commented Jul 25, 2024

I'll retry the cherrypick of this one once the remaining two cherrypicks of #21133 are in (#21203, #21204).

WorkerPants pushed a commit that referenced this pull request Jul 25, 2024
@tobni @WorkerPants
Allow unesecure node temporarily for manylinux container builds (#21172)
7e610dd 
Renders github actions and env settings to continue to use node16 inside
the containers that match the glibc (2.17) of manylinux_2014 builder
images. The new default node version for gha requires a much higher
version.

I checked if https://github.com/nodejs/unofficial-builds had node
binaries we could use. It does not.

Based on #21133
@WorkerPants
Copy link
Member

I tried to automatically cherry-pick this change back to each relevant milestone, so that it is available in those older releases of Pants.

❌ 2.20.x

I was unable to cherry-pick this PR to 2.20.x, likely due to merge-conflicts.

Steps to Cherry-Pick locally

To resolve:

  1. (Ensure your git working directory is clean)
  2. Run the following script to reproduce the merge-conflicts: 
    git fetch https://github.com/pantsbuild/pants main \
  && git fetch https://github.com/pantsbuild/pants 2.20.x \
  && git checkout -b cherry-pick-21172-to-2.20.x FETCH_HEAD \
  && git cherry-pick 7452afeed46bc4a26c1ed0fe5508d669fb3d7985
  3. Fix the merge conflicts and commit the changes
  4. Run build-support/cherry_pick/make_pr.sh "21172" "2.20.x"

Please note that I cannot re-run CI if a job fails. Please work with your PR approver(s) to re-run CI if necessary.

❌ 2.21.x

I was unable to cherry-pick this PR to 2.21.x, likely due to merge-conflicts.

Steps to Cherry-Pick locally

To resolve:

  1. (Ensure your git working directory is clean)
  2. Run the following script to reproduce the merge-conflicts: 
    git fetch https://github.com/pantsbuild/pants main \
  && git fetch https://github.com/pantsbuild/pants 2.21.x \
  && git checkout -b cherry-pick-21172-to-2.21.x FETCH_HEAD \
  && git cherry-pick 7452afeed46bc4a26c1ed0fe5508d669fb3d7985
  3. Fix the merge conflicts and commit the changes
  4. Run build-support/cherry_pick/make_pr.sh "21172" "2.21.x"

Please note that I cannot re-run CI if a job fails. Please work with your PR approver(s) to re-run CI if necessary.

✔️ 2.22.x

Successfully opened #21209.

When you're done manually cherry-picking, please remove the needs-cherrypick label on this PR.

Thanks again for your contributions!

🤖 Beep Boop here's my run link

huonw pushed a commit that referenced this pull request Jul 25, 2024
@WorkerPants @tobni
Allow unesecure node temporarily for manylinux container builds (Cher…
ba54545 
…ry-pick of #21172) (#21209)

Renders github actions and env settings to continue to use node16 inside
the containers that match the glibc (2.17) of manylinux_2014 builder
images. The new default node version for gha requires a much higher
version.

I checked if https://github.com/nodejs/unofficial-builds had node
binaries we could use. It does not.

Based on #21133

Co-authored-by: Tobias Nilsson <[email protected]>
huonw pushed a commit that referenced this pull request Jul 26, 2024
@tobni @huonw
Allow unesecure node temporarily for manylinux container builds (#21172)
ace9f9e 
Renders github actions and env settings to continue to use node16 inside
the containers that match the glibc (2.17) of manylinux_2014 builder
images. The new default node version for gha requires a much higher
version.

I checked if https://github.com/nodejs/unofficial-builds had node
binaries we could use. It does not.

Based on #21133
huonw pushed a commit that referenced this pull request Jul 26, 2024
@tobni @huonw
Allow unesecure node temporarily for manylinux container builds (#21172)
23fdf2e 
Renders github actions and env settings to continue to use node16 inside
the containers that match the glibc (2.17) of manylinux_2014 builder
images. The new default node version for gha requires a much higher
version.

I checked if https://github.com/nodejs/unofficial-builds had node
binaries we could use. It does not.

Based on #21133
huonw added a commit that referenced this pull request Jul 26, 2024
@huonw @tobni
Allow unesecure node temporarily for manylinux container builds (Cher…
95d97a9 
…ry-pick of #21172) (#21211)

Renders github actions and env settings to continue to use node16 inside
the containers that match the glibc (2.17) of manylinux_2014 builder
images. The new default node version for gha requires a much higher
version.

I checked if https://github.com/nodejs/unofficial-builds had node
binaries we could use. It does not.

Based on #21133

Co-authored-by: Tobias Nilsson <[email protected]>
huonw added a commit that referenced this pull request Jul 26, 2024
@huonw @tobni
Allow unesecure node temporarily for manylinux container builds (Cher…
1163174 
…ry-pick of #21172) (#21212)

Renders github actions and env settings to continue to use node16 inside
the containers that match the glibc (2.17) of manylinux_2014 builder
images. The new default node version for gha requires a much higher
version.

I checked if https://github.com/nodejs/unofficial-builds had node
binaries we could use. It does not.

Based on #21133

Co-authored-by: Tobias Nilsson <[email protected]>
@huonw huonw mentioned this pull request Nov 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjyw benjyw benjyw approved these changes

Assignees
No one assigned
Labels
auto-cherry-picking-failed Auto Cherry-Picking Failed category:internal CI, fixes for not-yet-released features, etc. release-notes:not-required PR doesn't require mention in release notes
Projects
None yet
Milestone
2.20.x
Development

Successfully merging this pull request may close these issues.
4 participants
@tobni @WorkerPants @huonw @benjyw