Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update release docs to work around file watcher race condition. #21081

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Update release docs to work around file watcher race condition. #21081

merged 1 commit into from
Jun 18, 2024

Conversation

benjyw
Copy link
Contributor

@benjyw benjyw commented Jun 17, 2024

The start_release.py script modifies workspace files,
and so will race with the file watcher to complete before
being killed and restarted. And since the process is not
idempotent (e.g., it creates a local git branch) that restarted
process can fail.

@benjyw
Update release docs to work around file watcher race condition.
3a2b35b 
The start_release.py script modifies workspace files, and so
will race with the file watcher to complete before being killed
and restarted.

And since the process is not idempotent (it creates a local git
branch) that restarted process will then fail.
@benjyw benjyw requested review from huonw and thejcannon June 17, 2024 14:25
@benjyw benjyw added the release-notes:not-required PR doesn't require mention in release notes label Jun 17, 2024
huonw
huonw approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@huonw huonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that is fun. That said, I thought interactive processes were not restartable/interruptible by default?

@benjyw
Copy link
Contributor Author

benjyw commented Jun 18, 2024

The process indeed isn't (I debug-printed the value of restartable which was False as expected), but apparently the entire @goal_rule will kill-and-restart (again, verified by debug prints) regardless, which makes restartable misleading I guess?

@benjyw benjyw merged commit d50f9d5 into pantsbuild:main Jun 18, 2024
25 checks passed
@benjyw benjyw deleted the improve_release_docs branch June 18, 2024 04:28
@benjyw benjyw mentioned this pull request Jun 22, 2024
Open
@purajit purajit mentioned this pull request Jun 26, 2024
Merged
@benjyw
Copy link
Contributor Author

benjyw commented Aug 13, 2024

This can be reverted post #21303

huonw added a commit that referenced this pull request Aug 21, 2024
@huonw
Revert "Update release docs to work around file watcher race conditio…
f9a5f85 
…n. (#21081)"

This reverts commit d50f9d5.
@huonw huonw mentioned this pull request Aug 21, 2024
Merged
huonw added a commit that referenced this pull request Aug 22, 2024
@huonw
Revert "Update release docs to work around file watcher race conditio…
763f461 
…n." (#21342)

Reverts #21081 now that we've fixed the real problem in
#21303
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huonw huonw huonw approved these changes

@thejcannon thejcannon Awaiting requested review from thejcannon

Assignees
No one assigned
Labels
category:documentation release-notes:not-required PR doesn't require mention in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benjyw @huonw