[Call-by-name] cc.lint.clang-format migration
#21071
Merged
+31
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sureshjoshi
added
the
category:internal
sureshjoshi
commented
Jun 16, 2024
| output_files=request.files, | ||
| description=f"Run clang-format on {pluralize(len(request.files), 'file')}.", | ||
| level=LogLevel.DEBUG, | ||
| argv = ( |
There was a problem hiding this comment.
This was required to fix a migration warning, where the AST isn't smart enough to perform the migration when there are comments inline.
Using libcst or something (#21040) is the way.
sureshjoshi
commented
Jun 16, 2024
| *request.files, | ||
| ) | ||
| result = await fallible_to_exec_result_or_raise( | ||
| **implicitly( |
There was a problem hiding this comment.
This solves a rule-graph error, where fallible_to... isn't expecting a PexProcess.
As per @stuhood https://pantsbuild.slack.com/archives/C0D7TNJHL/p1718575366615099?thread_ts=1718115214.921379&cid=C0D7TNJHL
if any sort of argument conversion is supposed to happen, then it should not be a positional argument: rather an **implicitly(PexProcess(..))
you call the function whose result you want, but you implicitly convert the arguments
cognifloyd
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was intended to be part of the
ccmigration (#21043), but I left it commented out from the backend packages by accident.See issue #21065 for tracking list.