Export venvs for a matrix of multiple python interpreters #20516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cognifloyd
force-pushed
the
cognifloyd/export-matrix
branch
from
391543a to
e7db0e6
Compare
cognifloyd
added
category:new feature
backend: Python
cognifloyd
force-pushed
the
cognifloyd/export-matrix
branch
from
e7db0e6 to
3eb5463
Compare
cognifloyd
added a commit
that referenced
this pull request
Jun 20, 2024
Instead of relying on the implicit pex interpreter resolution--based on interpreter_constraints--this PR makes the export pre-calculate which interpreter to use. This has the benefit of allowing pants to provide the python interpreter (eg with pyenv) if configured to do so. Without this, the exports can only use pre-installed interpreters. To make this work, I had to prevent the injection of `PexRequest.interpreter_constraints` when `PexRequest.python` is set. This refactor is pre-work for #20516.
cognifloyd
force-pushed
the
cognifloyd/export-matrix
branch
from
3eb5463 to
7ab6def
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted #21087 as pre-work for this PR.
Closes #15817