Add example using GHA cache backend #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaos
approved these changes
Nov 6, 2023
|
@riisi this is still a Draft. Should it be? |
|
Initially because this needs pants v2.19. But also will change slightly with some fixes to Docker backend that I’m working on now. Would hold off on merging for now. On 9 Nov 2023, at 23:30, Benjy Weinberger ***@***.***> wrote:
@riisi this is still a Draft. Should it be?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
2.19 is released. Is this ready to go again? |
|
I think this should be good to go now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raising for info at this stage pending 2.19 release.
Note that no changes are required to run this locally - i.e. it will not fail due to missing GH tokens but fall back to local cache if present.
I think I will also attempt to add an example using the Inline cache backend, publishing to Github packages - this seems a better option when there are many images as the GHA cache limit would be reached.